Bugzilla – Attachment 68904 Details for
Bug 19537
Authorities search doesn't correctly populate subfield $2 source of heading
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19537: (QA Follow-up) Consistent structures
Bug-19537-QA-Follow-up-Consistent-structures.patch (text/plain), 1.90 KB, created by
Marcel de Rooy
on 2017-11-03 07:27:32 UTC
(
hide
)
Description:
Bug 19537: (QA Follow-up) Consistent structures
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-11-03 07:27:32 UTC
Size:
1.90 KB
patch
obsolete
>From 35cd3771d8045589f586f33495c96275b127a388 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 3 Nov 2017 08:24:15 +0100 >Subject: [PATCH] Bug 19537: (QA Follow-up) Consistent structures >Content-Type: text/plain; charset=utf-8 > >The subfield_loop structure should contain things like: >$VAR1 = { > 'marc_subfield' => 'v', > 'marc_values' => [ > 'form' > ] > }; > >This patches replaces the list by an array ref to restore consistency, >although Template Toolkit does not really care. Both work. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > authorities/blinddetail-biblio-search.pl | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/authorities/blinddetail-biblio-search.pl b/authorities/blinddetail-biblio-search.pl >index 838e4ba..b7990f7 100755 >--- a/authorities/blinddetail-biblio-search.pl >+++ b/authorities/blinddetail-biblio-search.pl >@@ -122,9 +122,9 @@ if ($authid) { > $indicator2 = defined $thes_mapping{$thes_008_11} ? $thes_mapping{$thes_008_11} : $thes_008_11; > if ($indicator2 eq '7') { > if ($thes_008_11 eq 'r') { >- push @subfield_loop, { marc_subfield => '2', marc_values => ('aat') }; >+ push @subfield_loop, { marc_subfield => '2', marc_values => [ 'aat' ] }; > } elsif ($thes_008_11 eq 's') { >- push @subfield_loop, { marc_subfield => '2', marc_values => ('sears') }; >+ push @subfield_loop, { marc_subfield => '2', marc_values => [ 'sears' ] }; > } > } > } >@@ -161,6 +161,7 @@ $template->param( > SUBFIELD_LOOP => \@subfield_loop, > tag_number => $tag_number, > ); >+require Data::Dumper; warn Data::Dumper::Dumper(@subfield_loop); > > output_html_with_http_headers $query, $cookie, $template->output; > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19537
:
68677
|
68809
|
68903
|
68904
|
68905