Bugzilla – Attachment 69098 Details for
Bug 2454
Improve display of credits on pay fines tab
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 2454 - Removed the display of NotifyID and Level values on Pay fines page
Bug-2454---Removed-the-display-of-NotifyID-and-Lev.patch (text/plain), 2.72 KB, created by
Alex Buckley
on 2017-11-12 02:44:24 UTC
(
hide
)
Description:
Bug 2454 - Removed the display of NotifyID and Level values on Pay fines page
Filename:
MIME Type:
Creator:
Alex Buckley
Created:
2017-11-12 02:44:24 UTC
Size:
2.72 KB
patch
obsolete
>From ce9b1957731a076e444c240d5fe558c1276b78e4 Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Sun, 12 Nov 2017 02:31:51 +0000 >Subject: [PATCH] Bug 2454 - Removed the display of NotifyID and Level values > on Pay fines page > >Based on tester feedback this patch has been redone so as to remove >changes of indentation to lines not added or modified by this patch. > >Test plan: >1. From the Koha staff interface go the Patron area and select a patron >page > >2. Create a fine of $10 for the patron by clicking on the 'Fines' tab >and creating a fine in the 'Create manual invoice' tab > >3. Create a credit of $5 for the patron in the 'Create manual credit' >page > >4. Then go to the 'Pay fines' tab and notice there is a row for both the >fine and credit both with values in the account type, Notify ID, and level boxes >of the table > >5. Select "write off all" and 'OK' in the confirmation box > >6. Youre redirected to Account tab, return to 'pay fines' tab and notice >no fines or credits are displayed > >7. Repeat steps 2, 3, 4 and then click "Pay amount", confirm it, then >navigate back to the 'Pay fines' tab and notice although the fine and credit are >displayed the 'total due' value is 0.00 > >8. Apply the patch attached to this bug report > >9. Repeat steps 2, and 3. > >10. Navigate to 'Pay fines' tab and notice the fine has values >in account type, Notify ID, and level and the credit does not. >Additionally credit has the description value of 'Credit' > >11. Repeat steps 5 and 6 and as with before this patch was applied >notice the 'Pay fines' tab does not show any fines or credits > >12. Repeat step 7 and again notice the 'Total due' value is 0.00 > >Sponsored-By: Catalyst IT >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt | 7 +++++++ > 1 file changed, 7 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >index ead4ce4..4ee3d9a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >@@ -143,10 +143,17 @@ function enableCheckboxActions(){ > [%- IF line.description %], [% line.description %][% END %] > [% IF line.title %]([% line.title %])[% END %] > </td> >+ [% IF (line.amountoutstanding > 0) %] > <td><input type="text" name="payment_note_[% line.accountlines_id %]" /></td> > <td>[% line.accounttype %]</td> > <td>[% line.notify_id %]</td> > <td>[% line.notify_level %]</td> >+ [% ELSE %] >+ <td></td> >+ <td></td> >+ <td></td> >+ <td></td> >+ [% END %] > <td class="debit" style="text-align: right;">[% line.amount | $Price %]</td> > <td class="debit" style="text-align: right;">[% line.amountoutstanding | $Price %]</td> > </tr> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 2454
:
672
|
673
|
61764
|
61765
|
62194
|
62953
|
62991
|
62994
|
68470
|
69098
|
69210