From 84f7dbb8e98e37aa5e91136e261f70a4f979cd40 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 2 Nov 2017 10:26:08 -0300 Subject: [PATCH] Bug 18712: Remove unecessary fixtures 2 fixtures are in a subroutine that is never called, it can be removed Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens --- t/Biblio.t | 23 ----------------------- t/Calendar.t | 10 ---------- 2 files changed, 33 deletions(-) diff --git a/t/Biblio.t b/t/Biblio.t index 4ade7cc..446afe2 100755 --- a/t/Biblio.t +++ b/t/Biblio.t @@ -21,31 +21,8 @@ use Test::More; use Test::MockModule; use Test::Warn; -use Module::Load::Conditional qw/check_install/; - -BEGIN { - if ( check_install( module => 'Test::DBIx::Class' ) ) { - plan tests => 47; - } else { - plan skip_all => "Need Test::DBIx::Class" - } -} - use_ok('C4::Biblio'); -#use Test::DBIx::Class {}, 'Biblio'; -use Test::DBIx::Class; #No difference between these two invocations in time taken to execute tests. - -sub fixtures { - my ( $data ) = @_; - fixtures_ok [ - Biblio => [ - [ qw/ biblionumber datecreated timestamp / ], - @$data, - ], - ], 'add fixtures'; -} - my $db = Test::MockModule->new('Koha::Database'); $db->mock( _new_schema => sub { return Schema(); } ); diff --git a/t/Calendar.t b/t/Calendar.t index e0128b7..1c3f194 100755 --- a/t/Calendar.t +++ b/t/Calendar.t @@ -39,16 +39,6 @@ use_ok('Koha::Calendar'); use Test::DBIx::Class; -sub fixtures { - my ( $data ) = @_; - fixtures_ok [ - Biblio => [ - [ qw/ biblionumber datecreated timestamp / ], - @$data, - ], - ], 'add fixtures'; -} - my $db = Test::MockModule->new('Koha::Database'); $db->mock( _new_schema => sub { return Schema(); } -- 2.1.4