From 4db427743f3e565001d8f530685be3db1578d205 Mon Sep 17 00:00:00 2001 From: David Bourgault Date: Wed, 22 Nov 2017 16:55:09 -0500 Subject: [PATCH] Bug 19466 - Check if cardnumber mandatory Turns out this isn't a bug, since it is caused by 'cardnumber' being in the 'BorrowerMandatoryField' syspref. It is however confusing for the user that it suggested to leave the field blank when the field is required. To alleviate this I added a condition to the code; it will not suggest leaving the field blank if 'BorrowerMandatoryField' contains 'cardnumber'. To test: Before: 0) Enable autoMemberNum 1) Add 'cardnumber' to BorrowerMandatoryField 2) Go to create a user: a message will appear suggesting you leave the cardnumber field blank for autocalc, but when submitting the form it will show as required. Apply patch 2) Go to create a user: if 'cardnumber' is in BorrowerMandatoryField, the suggestion will not be shown. --- koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt index 8a17653..9c5c8b4 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ -651,7 +651,7 @@ $(document).ready(function() { [% ELSE %] [% ELSE %] Card number: -- 2.7.4