Bugzilla – Attachment 69301 Details for
Bug 19684
Colon char in MARC data breaks facets
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19684: Only replace first colon char in facets link
Bug-19684-Only-replace-first-colon-char-in-facets-.patch (text/plain), 1.29 KB, created by
Fridolin Somers
on 2017-11-23 10:37:02 UTC
(
hide
)
Description:
Bug 19684: Only replace first colon char in facets link
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2017-11-23 10:37:02 UTC
Size:
1.29 KB
patch
obsolete
>From f0692841c3c8792a182be25a5c00ebd64bd4391e Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Thu, 23 Nov 2017 11:27:08 +0100 >Subject: [PATCH] Bug 19684: Only replace first colon char in facets link > >When a MARC data used in some facet contains colon char ":", this facet is broken it leads to no result. >This is because all colon are replaced by = which is a CCL syntax char. > >This patch corrects by replacing only first occurence of colon char, that is the index not the data. > >Test plan : >1) Create a record with subject "Ainur: Yavanna" (650$a for MARC21 or 600$a for UNIMARC) >2) Index this record in Zebra >3) Perform a search that shows this subject in facets >4) Click on this facet link >5) You get the record as result >--- > C4/Search.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index 9278f26..327eae0 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -1760,7 +1760,7 @@ sub buildQuery { > $query =~ s/(?<=(st-numeric)):/=/g; > $query =~ s/(?<=(st-year)):/=/g; > $query =~ s/(?<=(st-date-normalized)):/=/g; >- $limit =~ s/:/=/g; >+ $limit =~ s/:/=/; > for ( $query, $query_desc, $limit, $limit_desc ) { > s/ +/ /g; # remove extra spaces > s/^ //g; # remove any beginning spaces >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19684
:
69301
|
72947