Bugzilla – Attachment 69346 Details for
Bug 19655
To.json doesn't escape newlines which can create invalid JSON
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19655: Add tests
Bug-19655-Add-tests.patch (text/plain), 1.91 KB, created by
Jonathan Druart
on 2017-11-26 15:55:47 UTC
(
hide
)
Description:
Bug 19655: Add tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-11-26 15:55:47 UTC
Size:
1.91 KB
patch
obsolete
>From 3a7d4c6faf1a46b27f147b1c7c72aaf194f325e9 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Sun, 26 Nov 2017 12:55:27 -0300 >Subject: [PATCH] Bug 19655: Add tests > >--- > t/db_dependent/Template/Plugin/To.t | 47 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 t/db_dependent/Template/Plugin/To.t > >diff --git a/t/db_dependent/Template/Plugin/To.t b/t/db_dependent/Template/Plugin/To.t >new file mode 100644 >index 0000000000..033891f816 >--- /dev/null >+++ b/t/db_dependent/Template/Plugin/To.t >@@ -0,0 +1,47 @@ >+#!/usr/bin/perl >+ >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it >+# under the terms of the GNU General Public License as published by >+# the Free Software Foundation; either version 3 of the License, or >+# (at your option) any later version. >+# >+# Koha is distributed in the hope that it will be useful, but >+# WITHOUT ANY WARRANTY; without even the implied warranty of >+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >+# GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License >+# along with Koha; if not, see <http://www.gnu.org/licenses>. >+ >+use Modern::Perl; >+ >+use Test::More tests => 1; >+use t::lib::TestBuilder; >+ >+use Koha::Template::Plugin::To; >+ >+my $schema = Koha::Database->new->schema; >+$schema->storage->txn_begin; >+ >+my $builder = t::lib::TestBuilder->new; >+ >+subtest 'json' => sub { >+ plan tests => 1; >+ my $patron = $builder->build_object( >+ { >+ class => 'Koha::Patrons', >+ value => { >+ borrowernotes => q| >+several >+lines|, >+ } >+ } >+ ); >+ my $expected_escaped_notes = q|\\\\nseveral\\\\nlines|; >+ is( Koha::Template::Plugin::To->json( $patron->borrowernotes ), $expected_escaped_notes ); >+}; >+ >+$schema->storage->txn_rollback; >+ >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19655
:
69235
|
69244
|
69326
| 69346 |
69732
|
69806