Bugzilla – Attachment 69371 Details for
Bug 19551
Cash register report has bad erroneous results from wrong order of operations
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19551 - Fix wrong order of operations in cash register report
Bug-19551---Fix-wrong-order-of-operations-in-cash-.patch (text/plain), 1.45 KB, created by
Marcel de Rooy
on 2017-11-27 12:12:11 UTC
(
hide
)
Description:
Bug 19551 - Fix wrong order of operations in cash register report
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-11-27 12:12:11 UTC
Size:
1.45 KB
patch
obsolete
>From ff3c73d4d5c043eb062be6cb640e4380839197f3 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 31 Oct 2017 13:17:26 +0000 >Subject: [PATCH] Bug 19551 - Fix wrong order of operations in cash register > report >Content-Type: text/plain; charset=utf-8 > >To test: >1 - Find or create a fine for a patron >2 - Write it off >3 - Home -> Reports -> Cash register >4 - Fill in current date and transaction type 'Write off' >5 - Click Submit >-- see your write off >6 - Fill in previous dates and transaction type 'Write off' >7 - Click Submit >-- see your write off (bad) >8 - Apply patch >9 - Rerun steps 3-7 >-- write only visible for current date. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > reports/cash_register_stats.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reports/cash_register_stats.pl b/reports/cash_register_stats.pl >index 158625d..0a1ff54 100755 >--- a/reports/cash_register_stats.pl >+++ b/reports/cash_register_stats.pl >@@ -75,7 +75,7 @@ if ($do_it) { > $whereTType = q{ AND accounttype IN ('Pay','C') }; > } else { #Single transac type > if ($transaction_type eq 'FORW') { >- $whereTType = q{ AND accounttype = 'FOR' OR accounttype = 'W' }; >+ $whereTType = q{ AND accounttype IN ('FOR','W') }; > } else { > $whereTType = q{ AND accounttype = ? }; > push @extra_params, $transaction_type; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19551
:
68857
|
68876
| 69371