Bugzilla – Attachment 69372 Details for
Bug 19533
Hold pulldown for itemtype is empty if hold placement needs override
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override
Bug-19533---Hold-pulldown-for-itemtype-is-empty-if.patch (text/plain), 1.37 KB, created by
Marcel de Rooy
on 2017-11-27 12:25:46 UTC
(
hide
)
Description:
Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-11-27 12:25:46 UTC
Size:
1.37 KB
patch
obsolete
>From 927102dae3f164d42a8dce361e9c1483cf66c3ce Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 26 Oct 2017 07:35:53 -0400 >Subject: [PATCH] Bug 19533 - Hold pulldown for itemtype is empty if hold > placement needs override >Content-Type: text/plain; charset=utf-8 > >Test Plan: >1) Enable AllowHoldPolicyOverride >2) Enable AllowHoldItemTypeSelection >3) Create a situation where adding a hold for a patron would trigger a tooManyReserves > warning. >4) Note the itemtype pulldown is empty >5) Apply this patch >6) Reload the page >7) Itemtype pulldown should have values > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > reserve/request.pl | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/reserve/request.pl b/reserve/request.pl >index f4cdc16..919de1f 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -485,6 +485,8 @@ foreach my $biblionumber (@biblionumbers) { > # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules > $item->{override} = 1; > $num_override++; >+ >+ push( @available_itemtypes, $item->{itype} ); > } > > # If none of the conditions hold true, then neither override nor available is set and the item cannot be checked >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19533
:
68593
|
68723
|
68805
| 69372