Bugzilla – Attachment 69488 Details for
Bug 19638
False positives for 'Update SQL' button
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19638: Remove false positive obsolete reports (auth_header.marcxml)
Bug-19638-Remove-false-positive-obsolete-reports-a.patch (text/plain), 1.52 KB, created by
Jonathan Druart
on 2017-12-04 18:42:39 UTC
(
hide
)
Description:
Bug 19638: Remove false positive obsolete reports (auth_header.marcxml)
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-12-04 18:42:39 UTC
Size:
1.52 KB
patch
obsolete
>From 7bdbadd1ead0db7e8315f871a8e840e67b91d7e9 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 4 Dec 2017 15:39:48 -0300 >Subject: [PATCH] Bug 19638: Remove false positive obsolete reports > (auth_header.marcxml) > >Bug 17898 tries to help users identify reports affected by the move of >marcxml to the biblio_metadata table, however, the auth_header table >still uses the column name 'marcxml' and so reports as needing updated >though it doesn't. > >C4::Reports::Guided::convert_sql only converts if the sql query contain >biblioitems and marcxml. >We should use the same regexp in the controler script. > >Test plan: >Use a sql report that use auth_header.marcxml (see >https://wiki.koha-community.org/wiki/SQL_Reports_Library) >After the this the report should not be longer marked as obsolete on the >report list view >--- > reports/guided_reports.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl >index bfd0a7646b..106ddb528b 100755 >--- a/reports/guided_reports.pl >+++ b/reports/guided_reports.pl >@@ -138,7 +138,7 @@ elsif ( $phase eq 'Build new' ) { > my $has_obsolete_reports; > for my $report ( @$reports ) { > $report->{results} = C4::Reports::Guided::get_results( $report->{id} ); >- if ( $report->{savedsql} =~ m|marcxml| ) { >+ if ( $report->{savedsql} =~ m|biblioitems| and $report->{savedsql} =~ m|marcxml| ) { > $report->{seems_obsolete} = 1; > $has_obsolete_reports++; > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19638
:
69488
|
69494
|
69495