Bugzilla – Attachment 69509 Details for
Bug 19750
Overdues without a fine rule add warnings to log
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19750 - Overdues without a fine rule add warnings to log
Bug-19750---Overdues-without-a-fine-rule-add-warni.patch (text/plain), 1.30 KB, created by
Kyle M Hall
on 2017-12-05 15:25:53 UTC
(
hide
)
Description:
Bug 19750 - Overdues without a fine rule add warnings to log
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2017-12-05 15:25:53 UTC
Size:
1.30 KB
patch
obsolete
>From 30a2164e7c499893fd39c21bc4e0e53e3b192e50 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 5 Dec 2017 10:23:45 -0500 >Subject: [PATCH] Bug 19750 - Overdues without a fine rule add warnings to log > >When running fines.pl, any overdue items that have no corresponding circulation rule will generate the following warning: > >Use of uninitialized value $amount in numeric gt (>) at /usr/share/koha/bin/cronjobs/fines.pl line 133. > >Test Plan: >1) Create a single circ rule >2) Backdate a checkout so it is overdue >3) Delete the circ rule >4) Run fines.pl, note the warning >5) Apply this patch >6) Run fines.pl, note the warning is gone >--- > misc/cronjobs/fines.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/misc/cronjobs/fines.pl b/misc/cronjobs/fines.pl >index 6c3f830..87c732e 100755 >--- a/misc/cronjobs/fines.pl >+++ b/misc/cronjobs/fines.pl >@@ -130,7 +130,7 @@ for my $overdue ( @{$overdues} ) { > # Don't update the fine if today is a holiday. > # This ensures that dropbox mode will remove the correct amount of fine. > if ( $mode eq 'production' && !$is_holiday{$branchcode} ) { >- if ( $amount > 0 ) { >+ if ( $amount && $amount > 0 ) { > UpdateFine( > { > issue_id => $overdue->{issue_id}, >-- >2.10.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19750
:
69509
|
71101
|
71110