Bugzilla – Attachment 6968 Details for
Bug 3651
Require patron login to send shelves and baskets
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 3651 Follow-up, Require patron login to send shelves and baskets
SIGNED-OFF-Bug-3651-Follow-up-Require-patron-login.patch (text/plain), 2.54 KB, created by
Katrin Fischer
on 2011-12-30 08:26:05 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 3651 Follow-up, Require patron login to send shelves and baskets
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2011-12-30 08:26:05 UTC
Size:
2.54 KB
patch
obsolete
>From 829185bf992de797ffb676212d8f20b651737b7c Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 29 Dec 2011 11:47:44 -0500 >Subject: [PATCH] [SIGNED-OFF] Bug 3651 Follow-up, Require patron login to > send shelves and baskets > >The fix for Bug 4289, "Add a syspref 'OpacPublic', to hide OPAC >search-bar and force authentication on all OPAC pages" incorrectly >made some page permissions dependent on the value of the OpacPublic >setting. Some pages should require authentication no matter what. > >This patch returns opac-sendbasket.pl to the state it was in before >Bug 4289, Bug 4274 notwithstanding. I have added the authentication >requirement to opac-sendshelf.pl to match. > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >1) sending cart requires login >2) sending shelf requires login >3) updating personal details requires login >--- > opac/opac-sendbasket.pl | 2 +- > opac/opac-sendshelf.pl | 2 +- > opac/opac-userupdate.pl | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/opac/opac-sendbasket.pl b/opac/opac-sendbasket.pl >index df1b4c5..6a6e825 100755 >--- a/opac/opac-sendbasket.pl >+++ b/opac/opac-sendbasket.pl >@@ -39,7 +39,7 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user ( > template_name => "opac-sendbasketform.tmpl", > query => $query, > type => "opac", >- authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ), >+ authnotrequired => 0, > flagsrequired => { borrow => 1 }, > } > ); >diff --git a/opac/opac-sendshelf.pl b/opac/opac-sendshelf.pl >index 1de95ae..6e60bc9 100755 >--- a/opac/opac-sendshelf.pl >+++ b/opac/opac-sendshelf.pl >@@ -41,7 +41,7 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user ( > template_name => "opac-sendshelfform.tmpl", > query => $query, > type => "opac", >- authnotrequired => 1, >+ authnotrequired => 0, > flagsrequired => { borrow => 1 }, > } > ); >diff --git a/opac/opac-userupdate.pl b/opac/opac-userupdate.pl >index f8273ce..86e562a 100755 >--- a/opac/opac-userupdate.pl >+++ b/opac/opac-userupdate.pl >@@ -40,7 +40,7 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user( > template_name => "opac-userupdate.tmpl", > query => $query, > type => "opac", >- authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ), >+ authnotrequired => 0, > flagsrequired => { borrow => 1 }, > debug => 1, > } >-- >1.7.5.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 3651
:
1481
|
6955
| 6968