From 4f3bc3fb7f691580bd72f0d9af1cb39acb666d36 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Mon, 11 Dec 2017 16:47:00 +0000 Subject: [PATCH] Bug 19767: serial-issues.pl is unused and should be removed This patch removes three unused files: serials/serial-issues.pl ...and its associated templates: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt To test, apply the patch and search the Koha codebase for references to any of those files. None should exist. Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec --- .../prog/en/modules/serials/serial-issues-full.tt | 97 ---------------- .../prog/en/modules/serials/serial-issues.tt | 122 --------------------- serials/serial-issues.pl | 108 ------------------ 3 files changed, 327 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt delete mode 100755 serials/serial-issues.pl diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt deleted file mode 100644 index fb020a0..0000000 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt +++ /dev/null @@ -1,97 +0,0 @@ -[% INCLUDE 'doc-head-open.inc' %] -Koha › Serials › Subscription information for biblio #[% biblionumber %] with title : [% bibliotitle %] -[% INCLUDE 'doc-head-close.inc' %] - - - - -[% UNLESS ( popup ) %] -[% INCLUDE 'header.inc' %] -[% INCLUDE 'serials-search.inc' %] - - -
- -
-
-
-

Subscription information for biblio #[% biblionumber %] with title : [% bibliotitle %]

-

- Back to biblio -[% END %] - [% FOREACH year IN years %] - [% IF ( year.year ) %] - [% year.year %] - [% END %] - [% END %] - Compact view -

- [% FOREACH year IN years %] - [% IF ( year.first ) %]
- [% ELSE %] - [% END %] - -
-
- -
-[% INCLUDE 'serials-menu.inc' %] -
-
-[% INCLUDE 'intranet-bottom.inc' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt deleted file mode 100644 index 7bc9feb..0000000 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt +++ /dev/null @@ -1,122 +0,0 @@ -[% INCLUDE 'doc-head-open.inc' %] -Koha › Serials › Subscription information for [% bibliotitle %] -[% INCLUDE 'doc-head-close.inc' %] - - -[% INCLUDE 'header.inc' %] -[% INCLUDE 'serials-search.inc' %] - - - -
- -
-
-
- -

Subscription information for [% bibliotitle %]

- -[% FOREACH subscription_LOO IN subscription_LOOP %] -
-

Subscription summary

-

It began on [% subscription_LOO.histstartdate %] and is issued every - - [% IF ( subscription_LOO.periodicity1 ) %] - day - [% END %] - [% IF ( subscription_LOO.periodicity2 ) %] - week - [% END %] - [% IF ( subscription_LOO.periodicity3 ) %] - 2 weeks - [% END %] - [% IF ( subscription_LOO.periodicity4 ) %] - 3 weeks - [% END %] - [% IF ( subscription_LOO.periodicity5 ) %] - month - [% END %] - [% IF ( subscription_LOO.periodicity6 ) %] - 2 months - [% END %] - [% IF ( subscription_LOO.periodicity7 ) %] - 3 months - [% END %] - [% IF ( subscription_LOO.periodicity8 ) %] - quarter - [% END %] - [% IF ( subscription_LOO.periodicity9 ) %] - 2 quarters - [% END %] - [% IF ( subscription_LOO.periodicity10 ) %] - year - [% END %] - [% IF ( subscription_LOO.periodicity11 ) %] - 2 years - [% END %] - - [% IF ( subscription_LOO.arrival1 ) %] - on Monday - [% END %] - [% IF ( subscription_LOO.arrival2 ) %] - on Tuesday - [% END %] - [% IF ( subscription_LOO.arrival3 ) %] - on Wednesday - [% END %] - [% IF ( subscription_LOO.arrival4 ) %] - on Thursday - [% END %] - [% IF ( subscription_LOO.arrival5 ) %] - on Friday - [% END %] - [% IF ( subscription_LOO.arrival6 ) %] - on Saturday - [% END %] - [% IF ( subscription_LOO.arrival7 ) %] - on Sunday - [% END %] - for - [% IF ( subscription_LOO.numberlength ) %][% subscription_LOO.numberlength %] issues[% END %] - [% IF ( subscription_LOO.weeklength ) %][% subscription_LOO.weeklength %] weeks[% END %] - [% IF ( subscription_LOO.monthlength ) %][% subscription_LOO.monthlength %] months[% END %] - -

-

Last renewal of subscription was [% subscription_LOO.startdate %]

- [% IF ( subscription_LOO.enddate ) %]

This subscription is now ended. The last issue was received on [% subscription_LOO.enddate %]

[% END %] - [% UNLESS ( subscription_LOO.fullinfo ) %] -

[% subscription_LOO.notes %]

- [% IF ( subscription_LOO.opacnote ) %] -

Issues summary

-

- [% subscription_LOO.opacnote %] -

- [% END %] - [% IF ( subscription_LOO.recievedlist ) %] -

Received issues

-

- [% subscription_LOO.recievedlist %] -

- [% END %] - [% IF ( subscription_LOO.missinglist ) %] -

Missing issues

-

- [% subscription_LOO.missinglist %] -

- [% END %] -
- [% END %] -[% END %] - -
-
- -
-[% INCLUDE 'serials-menu.inc' %] -
-
-[% INCLUDE 'intranet-bottom.inc' %] diff --git a/serials/serial-issues.pl b/serials/serial-issues.pl deleted file mode 100755 index fdda1fd..0000000 --- a/serials/serial-issues.pl +++ /dev/null @@ -1,108 +0,0 @@ -#!/usr/bin/perl - -# Copyright 2000-2002 Katipo Communications -# -# This file is part of Koha. -# -# Koha is free software; you can redistribute it and/or modify it -# under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 3 of the License, or -# (at your option) any later version. -# -# Koha is distributed in the hope that it will be useful, but -# WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with Koha; if not, see . - - -=head1 NAME - -serial-issue.pl - -=head1 DESCRIPTION - -this script give more information about a susbcription given on input arg. - -=head1 PARAMETERS - -=over 4 - -=item selectview -can be equal to "full" or not. - -=item biblionumber -the biblionumber this script has to give more infos. - -=back - - -=cut - -use strict; -use warnings; -use CGI qw ( -utf8 ); -use C4::Auth; -use C4::Koha; -use C4::Serials; -use C4::Output; -use C4::Context; - - -my $query = new CGI; -my $dbh = C4::Context->dbh; -my $selectview = $query->param('selectview'); -$selectview = C4::Context->preference("SubscriptionHistory") unless $selectview; - -my ($template, $loggedinuser, $cookie); -my $biblionumber = $query->param('biblionumber'); -if ($selectview eq "full"){ - my $subscriptions = GetFullSubscriptionsFromBiblionumber($biblionumber); - - my $title = $subscriptions->[0]{bibliotitle}; - my $yearmin=$subscriptions->[0]{year}; - my $yearmax=$subscriptions->[scalar(@$subscriptions)-1]{year}; - - ($template, $loggedinuser, $cookie) - = get_template_and_user({template_name => "serials/serial-issues-full.tt", - query => $query, - type => "intranet", - flagsrequired => {serials => '*'}, - }); - - # replace CR by
in librarian note - # $subscription->{opacnote} =~ s/\n/\/g; - - $template->param( - biblionumber => scalar $query->param('biblionumber'), - years => $subscriptions, - yearmin => $yearmin, - yearmax =>$yearmax, - bibliotitle => $title, - suggestion => C4::Context->preference("suggestion"), - virtualshelves => C4::Context->preference("virtualshelves"), - ); - -} else { - my $subscriptions = GetSubscriptionsFromBiblionumber($biblionumber); - ($template, $loggedinuser, $cookie) - = get_template_and_user({template_name => "serials/serial-issues.tt", - query => $query, - type => "intranet", - flagsrequired => {serials => '*'}, - }); - - # replace CR by
in librarian note - # $subscription->{opacnote} =~ s/\n/\/g; - - $template->param( - biblionumber => "".$query->param('biblionumber'), - subscription_LOOP => $subscriptions, - suggestion => "".C4::Context->preference("suggestion"), - virtualshelves => "".C4::Context->preference("virtualshelves"), - ); -} -$template->param((uc(C4::Context->preference("marcflavour"))) => 1); -output_html_with_http_headers $query, $cookie, $template->output; -- 2.1.4