From 17be50b64927d3ab3c6a88a304ca950836f49495 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 12 Sep 2017 14:04:08 -0300 Subject: [PATCH] Bug 19301: Remove C4::Reserves::OnShelfHoldsAllowed At this point the subroutine is not used anymore Signed-off-by: Alex Buckley --- C4/Reserves.pm | 23 ----------------------- t/db_dependent/Reserves.t | 26 +------------------------- 2 files changed, 1 insertion(+), 48 deletions(-) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index 71e63aae43..b9a3e009ea 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -1148,22 +1148,6 @@ sub IsAvailableForItemLevelRequest { } } -=head2 OnShelfHoldsAllowed - - OnShelfHoldsAllowed($itemtype,$borrowercategory,$branchcode); - -Checks issuingrules, using the borrowers categorycode, the itemtype, and branchcode to see if onshelf -holds are allowed, returns true if so. - -=cut - -sub OnShelfHoldsAllowed { - my ($item, $borrower) = @_; - - my $itype = _get_itype($item); - return _OnShelfHoldsAllowed($itype,$borrower->{categorycode},$item->{holdingbranch}); -} - sub _get_itype { my $item = shift; @@ -1191,13 +1175,6 @@ sub _get_itype { return $itype; } -sub _OnShelfHoldsAllowed { - my ($itype,$borrowercategory,$branchcode) = @_; - - my $issuing_rule = Koha::IssuingRules->get_effective_issuing_rule({ categorycode => $borrowercategory, itemtype => $itype, branchcode => $branchcode }); - return $issuing_rule ? $issuing_rule->onshelfholds : undef; -} - =head2 AlterPriority AlterPriority( $where, $reserve_id ); diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t index 992e878c03..57de1ddd8f 100755 --- a/t/db_dependent/Reserves.t +++ b/t/db_dependent/Reserves.t @@ -17,7 +17,7 @@ use Modern::Perl; -use Test::More tests => 58; +use Test::More tests => 56; use Test::MockModule; use Test::Warn; @@ -540,30 +540,6 @@ $item = GetItem($itemnumber); ok( C4::Reserves::IsAvailableForItemLevelRequest($item, $borrower), "Reserving a book on item level" ); -my $itype = C4::Reserves::_get_itype($item); -my $categorycode = $borrower->{categorycode}; -my $holdingbranch = $item->{holdingbranch}; -my $issuing_rule = Koha::IssuingRules->get_effective_issuing_rule( - { - categorycode => $categorycode, - itemtype => $itype, - branchcode => $holdingbranch - } -); - -$dbh->do( - "UPDATE issuingrules SET onshelfholds = 1 WHERE categorycode = ? AND itemtype= ? and branchcode = ?", - undef, - $issuing_rule->categorycode, $issuing_rule->itemtype, $issuing_rule->branchcode -); -ok( C4::Reserves::OnShelfHoldsAllowed($item, $borrower), "OnShelfHoldsAllowed() allowed" ); -$dbh->do( - "UPDATE issuingrules SET onshelfholds = 0 WHERE categorycode = ? AND itemtype= ? and branchcode = ?", - undef, - $issuing_rule->categorycode, $issuing_rule->itemtype, $issuing_rule->branchcode -); -ok( !C4::Reserves::OnShelfHoldsAllowed($item, $borrower), "OnShelfHoldsAllowed() disallowed" ); - # tests for MoveReserve in relation to ConfirmFutureHolds (BZ 14526) # hold from A pos 1, today, no fut holds: MoveReserve should fill it $dbh->do('DELETE FROM reserves', undef, ($bibnum)); -- 2.11.0