Bugzilla – Attachment 70088 Details for
Bug 19840
Patron note is not displayed on checkin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19840: Fix - display patron note on checkin
Bug-19840-Fix---display-patron-note-on-checkin.patch (text/plain), 1.77 KB, created by
Josef Moravec
on 2017-12-21 21:35:49 UTC
(
hide
)
Description:
Bug 19840: Fix - display patron note on checkin
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2017-12-21 21:35:49 UTC
Size:
1.77 KB
patch
obsolete
>From d3af116bae93a0138e187d03132c15e9f5966b9d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 19 Dec 2017 15:40:45 -0300 >Subject: [PATCH] Bug 19840: Fix - display patron note on checkin > >If a patron let a note on the checkout (AllowCheckoutNotes), it is >supposed to be displayed when checked in. > >Test plan: >1/ Enable AllowCheckoutNotes >2/ Check an item out >3/ At the opac let a note on the checkout >4/ Check the item in > => With this patch applied you should see the notes displayed > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > circ/returns.pl | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > >diff --git a/circ/returns.pl b/circ/returns.pl >index 91eb5cb..c69310b 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -281,9 +281,8 @@ if ($barcode) { > my $descriptions = Koha::AuthorisedValues->get_description_by_koha_field({frameworkcode => '', kohafield =>'items.materials', authorised_value => $materials }); > $materials = $descriptions->{lib} // $materials; > >- my $issue = Koha::Checkouts->find( { itemnumber => $itemnumber } ); >- >- my $biblio = $item->biblio; >+ my $checkout = $item->checkout; >+ my $biblio = $item->biblio; > $template->param( > title => $biblio->title, > homebranch => $item->homebranch, >@@ -297,7 +296,7 @@ if ($barcode) { > biblionumber => $biblio->biblionumber, > borrower => $borrower, > additional_materials => $materials, >- issue => $issue, >+ issue => $checkout, > ); > } # FIXME else we should not call AddReturn but set BadBarcode directly instead > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19840
:
69923
|
69924
|
70054
|
70055
| 70088 |
70089