Bugzilla – Attachment 70289 Details for
Bug 19911
Passwords displayed to user during self-registration are not HTML-encoded
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19911: Escape password value during self-registration confirmation
Bug-19911-Escape-password-value-during-self-regist.patch (text/plain), 2.29 KB, created by
Jonathan Druart
on 2018-01-05 14:13:17 UTC
(
hide
)
Description:
Bug 19911: Escape password value during self-registration confirmation
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-01-05 14:13:17 UTC
Size:
2.29 KB
patch
obsolete
>From 4255a3682cc03bd3c036bb75d15f8476d2e7eac7 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 3 Jan 2018 16:15:18 -0300 >Subject: [PATCH] Bug 19911: Escape password value during self-registration > confirmation > >The password must be correctly escape, it can contains html character >and break the display. > >Test plan: >Apply first patch and confirm that the display is broken >Apply second patch (this one) and confirm that the display is fixed >--- > .../opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt >index caeec9c0e0..568ab4412c 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt >@@ -42,7 +42,7 @@ > </p> > <p id="patron-password-p"> > <span id="patron-password-label">Password:</span> >- <span id="patron-password">[% password_cleartext %]</span> >+ <span id="patron-password">[% password_cleartext | html %]</span> > </p> > > [% IF borrower.cardnumber %] >@@ -78,7 +78,7 @@ > [% END %] > <label for="password">Password:</label> > [% IF Koha.Preference('PatronSelfRegistrationPrefillForm') %] >- <input type="password" id="password" size="10" name="password" value="[% password_cleartext %]" /> >+ <input type="password" id="password" size="10" name="password" value="[% password_cleartext | html %]" /> > [% ELSE %] > <input type="password" id="password" size="10" name="password" value="" /> > [% END %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19911
:
70252
|
70253
|
70271
|
70289
|
70308
|
70309
|
70445
|
70446