Bugzilla – Attachment 70308 Details for
Bug 19911
Passwords displayed to user during self-registration are not HTML-encoded
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19911: Do not escape html characters when saving passwords
Bug-19911-Do-not-escape-html-characters-when-savin.patch (text/plain), 1.40 KB, created by
Biblibre Sandboxes
on 2018-01-05 17:23:43 UTC
(
hide
)
Description:
Bug 19911: Do not escape html characters when saving passwords
Filename:
MIME Type:
Creator:
Biblibre Sandboxes
Created:
2018-01-05 17:23:43 UTC
Size:
1.40 KB
patch
obsolete
>From 9ddad6d1696613bff35c8eb6d4c9b320b2ebd661 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 4 Jan 2018 11:00:35 -0300 >Subject: [PATCH] Bug 19911: Do not escape html characters when saving > passwords > >When the password is not generated automatically, we should not escape >the html characters. Otherwise it will be changed without any warnings. > >Signed-off-by: Arturo <alongoria@sll.texas.gov> >--- > opac/opac-memberentry.pl | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > >diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl >index 9ec5005..12eebbb 100755 >--- a/opac/opac-memberentry.pl >+++ b/opac/opac-memberentry.pl >@@ -441,10 +441,15 @@ sub ParseCgiForBorrower { > my $scrubber = C4::Scrubber->new(); > my %borrower; > >- foreach ( $cgi->param ) { >- if ( $_ =~ '^borrower_' ) { >- my ($key) = substr( $_, 9 ); >- $borrower{$key} = $scrubber->scrub( scalar $cgi->param($_) ); >+ foreach my $field ( $cgi->param ) { >+ if ( $field =~ '^borrower_' ) { >+ my ($key) = substr( $field, 9 ); >+ if ( $field !~ '^borrower_password' ) { >+ $borrower{$key} = $scrubber->scrub( scalar $cgi->param($field) ); >+ } else { >+ # Allow html characters for passwords >+ $borrower{$key} = $cgi->param($field); >+ } > } > } > >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19911
:
70252
|
70253
|
70271
|
70289
|
70308
|
70309
|
70445
|
70446