Bugzilla – Attachment 70324 Details for
Bug 16782
Display JSON report URL in staff client report interface
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16782: (QA Followup) Use Koha.Preference for staffClientBaseURL and provide classes
Bug-16782-QA-Followup-Use-KohaPreference-for-staff.patch (text/plain), 3.03 KB, created by
Nick Clemens
on 2018-01-08 15:40:06 UTC
(
hide
)
Description:
Bug 16782: (QA Followup) Use Koha.Preference for staffClientBaseURL and provide classes
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2018-01-08 15:40:06 UTC
Size:
3.03 KB
patch
obsolete
>From 05735853427613b1c18f279eee9713b1850b6c26 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 8 Jan 2018 15:37:45 +0000 >Subject: [PATCH] Bug 16782: (QA Followup) Use Koha.Preference for > staffClientBaseURL and provide classes > >--- > .../prog/en/modules/reports/guided_reports_start.tt | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 3ae5c9e..b9daca6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -163,8 +163,8 @@ canned reports and writing custom SQL reports.</p> > <th class="title-string">Creation date</th> > <th class="title-string">Last edit</th> > <th class="title-string">Last run</th> >- <th>Public</th> >- <th>JSON URL</th> >+ <th class="report_public">Public</th> >+ <th class="report_json_url">JSON URL</th> > [% IF (usecache) %] <th>Cache expiry (seconds)</th> [% END %] > <th>Saved results</th> > [% IF has_obsolete_reports %]<th>Update</th>[% END %] >@@ -195,18 +195,18 @@ canned reports and writing custom SQL reports.</p> > <td><span title="[% savedreport.date_created %]">[% savedreport.date_created | $KohaDates %]</span></td> > <td><span title="[% savedreport.last_modified %]">[% savedreport.last_modified | $KohaDates with_hours => 1 %]</span></td> > <td><span title="[% savedreport.last_run %]">[% savedreport.last_run | $KohaDates with_hours => 1 %]</span></td> >- <td> >+ <td class="report_public"> > [% IF (savedreport.public) %] > Yes > [% ELSE %] > No > [% END %] > </td> >- <td> >+ <td class="report_json_url"> > [% IF (savedreport.public) %] > <a href="[% OPACBaseURL %]/cgi-bin/koha/svc/report?id=[% savedreport.id | html %]">[% OPACBaseURL %]/cgi-bin/koha/svc/report?id=[% savedreport.id | html %]</a> > [% ELSE %] >- <a href="/cgi-bin/koha/svc/report?id=[% savedreport.id | html %]">[% staffClientBaseURL %]/cgi-bin/koha/svc/report?id=[% savedreport.id | html %]</a> >+ <a href="/cgi-bin/koha/svc/report?id=[% savedreport.id | html %]">[% Koha.Preference('staffClientBaseURL') %]/cgi-bin/koha/svc/report?id=[% savedreport.id | html %]</a> > [% END %] > </td> > [% IF (usecache) %] <td>[% savedreport.cache_expiry %]</td> [% END %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16782
:
68286
|
68287
|
68446
|
68447
|
68619
|
68620
|
68621
|
68639
|
68648
|
68649
|
70322
|
70323
| 70324 |
70395