Bugzilla – Attachment 70334 Details for
Bug 19913
Embedded HTML5 videos are broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19913: Fix embedded HTML5 videos at the OPAC
Bug-19913-Fix-embedded-HTML5-videos-at-the-OPAC.patch (text/plain), 1.80 KB, created by
Nick Clemens
on 2018-01-09 01:13:40 UTC
(
hide
)
Description:
Bug 19913: Fix embedded HTML5 videos at the OPAC
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2018-01-09 01:13:40 UTC
Size:
1.80 KB
patch
obsolete
>From 2b6caecf2e9af12692b5842c1f8c79931e6bf0a9 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 3 Jan 2018 18:12:33 -0300 >Subject: [PATCH] Bug 19913: Fix embedded HTML5 videos at the OPAC > >Caused by >commit 752aef4593f1aa2d64700bf9738e7e03907eb1cd >Bug 18754: Translatability: Get rid of exposed tt directives in opac-detail.tt > >A space is missing between 'source' and 'src' > >Test plan: >Set HTML5MediaEnabled to OPAC >Put a video link to 856$u >See the OPAC detail page, tab video, click the video >=> Should play with this patch applied > >Note that this does not affect intranet > >Signed-off-by: George <george@nekls.org> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 664cab7..14bc426 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -1027,7 +1027,7 @@ > <p> > [% SET ctrl_preload = ' controls preload=none' #translatability %] > <[% HTML5MediaParent _ ctrl_preload %] > >- <[% HTML5MediaSet.child _ 'src="' _ HTML5MediaSet.srcblock _'"' _ HTML5MediaSet.typeblock %] /> >+ <[% HTML5MediaSet.child _ ' src="' _ HTML5MediaSet.srcblock _'"' _ HTML5MediaSet.typeblock %] /> > <span>[[% HTML5MediaParent %] tag not supported by your browser.]</span> > </[% HTML5MediaParent %]> > </p> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19913
:
70255
|
70333
| 70334