From e031ff27a41ea7e3467ff46f04735bca976e828c Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 8 Jan 2018 11:40:10 -0300 Subject: [PATCH] Bug 19935: Replace GetPendingIssues - summary-print We are in the notices part, so we need to fetch all the data to avoid regressions. Test plan: Print a summary slip before and after this patch. They must be the same --- members/summary-print.pl | 31 +++++++++++++++---------------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/members/summary-print.pl b/members/summary-print.pl index a860a06902..8a6a3a364f 100755 --- a/members/summary-print.pl +++ b/members/summary-print.pl @@ -83,36 +83,35 @@ output_html_with_http_headers $input, $cookie, $template->output; sub build_issue_data { my ( $borrowernumber ) = @_; - my $issues = GetPendingIssues( $borrowernumber ); + my $patron = Koha::Patrons->find( $borrowernumber ); + return unless $patron; - my $return = []; + my $pending_checkouts = $patron->pending_checkouts->search( {}, + { order_by => [ { -desc => 'date_due' }, { -asc => 'issue_id' } ] } ); - my $today = DateTime->now( time_zone => C4::Context->tz ); - $today->truncate( to => 'day' ); + my @checkouts; - foreach my $issue ( @{$issues} ) { + while ( my $c = $pending_checkouts->next ) { + my $checkout = $c->unblessed_all_relateds; - my %row = %{$issue}; - $totalprice += $issue->{replacementprice} - if ( $issue->{replacementprice} ); + $totalprice += $checkout->{replacementprice} + if $checkout->{replacementprice}; #find the charge for an item my ( $charge, $itemtype ) = - GetIssuingCharges( $issue->{itemnumber}, $borrowernumber ); + GetIssuingCharges( $checkout->{itemnumber}, $borrowernumber ); $itemtype = Koha::ItemTypes->find( $itemtype ); - $row{'itemtype_description'} = $itemtype->description; #FIXME Should not it be translated_description + $checkout->{itemtype_description} = $itemtype->description; #FIXME Should not it be translated_description - $row{'charge'} = sprintf( "%.2f", $charge ); + $checkout->{charge} = sprintf( "%.2f", $charge ); # TODO Should be done in the template using Price - $row{date_due} = $row{date_due_sql}; + $checkout->{overdue} = $c->is_overdue; - push( @{$return}, \%row ); + push @checkouts, $checkout; } - @{$return} = sort { $a->{date_due} eq $b->{date_due} } @{$return}; - - return $return; + return \@checkouts; } -- 2.11.0