From 6ab0e60149ef0bd63e701757d9e528ca6c5d562b Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Fri, 29 Sep 2017 13:43:58 -0400 Subject: [PATCH] Bug 18856: Don't show cancel option for waiting holds in OPAC If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds Signed-off-by: Kyle M Hall Signed-off-by: Caroline Cyr La Rose Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt index 35cf5a0..77e601b 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt @@ -740,7 +740,7 @@ Using this account is not recommended because some parts of Koha will not functi [% END # / IF SuspendHoldsOpac %] - [% IF ( RESERVE.is_cancelable ) %] + [% IF ( ! RESERVE.is_found ) %]
-- 2.1.4