From f11c1941ded6a50ed01d79f4ec1c6bd342d4ba6c Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Tue, 9 Jan 2018 18:15:30 +0000 Subject: [PATCH] Bug 19938: Refactor checkoverdues call in C4/Members.pm Due to concerns that another bug may conflict, this was purposefully split. The other bug removes patronflags(). It is this function that has the C4::Overdues::checkoverdues call refactored. TEST PLAN --------- Apply both patches and follow the test plan in the larger one. Signed-off-by: Lee Jamison Signed-off-by: Julian Maurice --- C4/Members.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/C4/Members.pm b/C4/Members.pm index faa497f98c..d4a82c0164 100644 --- a/C4/Members.pm +++ b/C4/Members.pm @@ -248,7 +248,8 @@ sub patronflags { $flaginfo{'message'} = $patroninformation->{'borrowernotes'}; $flags{'NOTES'} = \%flaginfo; } - my ( $odues, $itemsoverdue ) = C4::Overdues::checkoverdues($patroninformation->{'borrowernumber'}); + my $itemsoverdue = C4::Overdues::checkoverdues($patroninformation->{'borrowernumber'}); + my $odues = $itemsoverdue ? scalar(@$itemsoverdue) : 0; if ( $odues && $odues > 0 ) { my %flaginfo; $flaginfo{'message'} = "Yes"; -- 2.11.0