Bugzilla – Attachment 705 Details for
Bug 2505
Omnibus: Enable Perl warnings in all modules and scripts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch for opac-ics.pl and opac-search-history.pl
0009-Bug-2505-Adds-warnings-to-opac-ics.pl-and-opac-sear.patch (text/plain), 1.47 KB, created by
Chris Cormack
on 2010-02-02 23:56:00 UTC
(
hide
)
Description:
Proposed patch for opac-ics.pl and opac-search-history.pl
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2010-02-02 23:56:00 UTC
Size:
1.47 KB
patch
obsolete
>From f299b18add0303df492b1876e33c385dbed1e984 Mon Sep 17 00:00:00 2001 >From: Garry Collum <gcollum@gmail.com> >Date: Tue, 2 Feb 2010 19:01:57 -0500 >Subject: [PATCH] Bug 2505: Adds warnings to opac-ics.pl and opac-search-history.pl >Content-Type: text/plain; charset="utf-8" > >No warnings generated from opac-ics.pl >Fixes warnings for opac-search-history.pl >--- > opac/opac-ics.pl | 2 ++ > opac/opac-search-history.pl | 4 +++- > 2 files changed, 5 insertions(+), 1 deletions(-) > >diff --git a/opac/opac-ics.pl b/opac/opac-ics.pl >index 9206e8b..2b06517 100755 >--- a/opac/opac-ics.pl >+++ b/opac/opac-ics.pl >@@ -20,6 +20,8 @@ > # This script builds an ICalendar file (rfc 2445) for use in programs such as Ical > > use strict; >+use warnings; >+ > use CGI; > use Data::ICal; > use Data::ICal::Entry::Event; >diff --git a/opac/opac-search-history.pl b/opac/opac-search-history.pl >index 97db2d5..8c461d2 100755 >--- a/opac/opac-search-history.pl >+++ b/opac/opac-search-history.pl >@@ -18,6 +18,8 @@ > # Suite 330, Boston, MA 02111-1307 USA > > use strict; >+use warnings; >+ > use C4::Auth qw(:DEFAULT get_session); > use CGI; > use Storable qw(freeze thaw); >@@ -46,7 +48,7 @@ my ($template, $loggedinuser, $cookie) > $template->param(dateformat => C4::Context->preference("dateformat")); > > # If the user is not logged in, we deal with the cookie >-if ($loggedinuser == '') { >+if (!$loggedinuser) { > > # Deleting search history > if ($cgi->param('action') && $cgi->param('action') eq 'delete') { >-- >1.5.6.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 2505
:
686
|
687
|
688
|
689
|
690
|
691
|
692
|
693
|
694
|
695
|
696
|
697
|
698
|
699
|
700
|
701
|
702
|
703
|
704
|
705
|
706
|
707
|
708
|
709
|
2223
|
3884
|
4574
|
8209
|
8317
|
8322
|
8373
|
9034
|
9035
|
9036
|
34442