Bugzilla – Attachment 7051 Details for
Bug 6829
Remove two warnings for opac-MARCdetail
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Second follow up
patch.txt (text/plain), 1.90 KB, created by
Marcel de Rooy
on 2012-01-05 13:57:32 UTC
(
hide
)
Description:
Second follow up
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2012-01-05 13:57:32 UTC
Size:
1.90 KB
patch
obsolete
>From 329343f6d51c1c724c8402e47f6a805a77a4f518 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 5 Jan 2012 14:45:06 +0100 >Subject: [PATCH] 6829 Follow up >Content-Type: text/plain; charset="utf-8" > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Needed this second follow up to remove 952-0 from the display again, coming up after the first follow up. >Changed a second test in accordance with first follow up. >Removed a useless 10th loop to create a tab10XX that is not in the template. >--- > opac/opac-MARCdetail.pl | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/opac/opac-MARCdetail.pl b/opac/opac-MARCdetail.pl >index 272ac0c..f408cd2 100755 >--- a/opac/opac-MARCdetail.pl >+++ b/opac/opac-MARCdetail.pl >@@ -95,7 +95,7 @@ my @loop_data = (); > my $tag; > > # loop through each tab 0 through 9 >-for ( my $tabloop = 0 ; $tabloop <= 10 ; $tabloop++ ) { >+for ( my $tabloop = 0 ; $tabloop <= 9 ; $tabloop++ ) { > > # loop through each tag > my @loop_data = (); >@@ -140,7 +140,7 @@ for ( my $tabloop = 0 ; $tabloop <= 10 ; $tabloop++ ) { > my $previous = ''; > # loop through each subfield > for my $i ( 0 .. $#subf ) { >- $subf[$i][0] = "@" unless $subf[$i][0]; >+ $subf[$i][0] = "@" unless defined($subf[$i][0]); > my $sf_def = $tagslib->{ $fields[$x_i]->tag() }->{ $subf[$i][0] }; > next if ( ($sf_def->{tab}||0) != $tabloop ); > next if ( ($sf_def->{hidden}||0) > 0 ); >@@ -215,7 +215,7 @@ foreach my $field (@fields) { > # loop through each subfield > for my $i ( 0 .. $#subf ) { > my $sf_def = $tagslib->{ $field->tag() }->{ $subf[$i][0] }; >- next if ( ($sf_def->{tab}||'') ne 10 ); >+ next if ( ($sf_def->{tab}||0) != 10 ); > next if ( ($sf_def->{hidden}||0) > 0 ); > $witness{ $subf[$i][0] } = $sf_def->{lib}; > >-- >1.6.0.6 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6829
:
5253
|
5254
|
5255
|
5256
|
5257
|
6931
|
7035
| 7051