From 8b777921fb6f094feb9ca5868cf90bb3cc61341a Mon Sep 17 00:00:00 2001
From: Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com>
Date: Thu, 6 Jul 2017 16:34:32 +0200
Subject: [PATCH] Bug 11897: Follow up: Check syspref before stockrotation
 access.

* koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc: Add
  check for syspref.
* koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc: Add check
  for syspref.
* koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt: Add
  check for syspref.
* tools/stockrotation.pl: Add check for syspref.
* catalogue/stockrotation.pl: Add check for syspref.

Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk>
---
 catalogue/stockrotation.pl                          |  6 ++++++
 .../prog/en/includes/biblio-view-menu.inc           |  2 +-
 .../intranet-tmpl/prog/en/includes/tools-menu.inc   | 21 ++++++++++++++++++++-
 .../prog/en/modules/tools/tools-home.tt             |  4 +++-
 tools/stockrotation.pl                              |  7 +++++++
 5 files changed, 37 insertions(+), 3 deletions(-)

diff --git a/catalogue/stockrotation.pl b/catalogue/stockrotation.pl
index 8969b5bb12..ff63b8a270 100755
--- a/catalogue/stockrotation.pl
+++ b/catalogue/stockrotation.pl
@@ -39,6 +39,12 @@ use Koha::Util::StockRotation qw(:ALL);
 
 my $input = new CGI;
 
+unless (C4::Context->preference('StockRotation')) {
+    # redirect to Intranet home if self-check is not enabled
+    print $input->redirect("/cgi-bin/koha/mainpage.pl");
+    exit;
+}
+
 my %params = $input->Vars();
 
 my $op = $params{op};
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
index 0253b8c90a..b32f60939e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
@@ -40,7 +40,7 @@
 [% IF ( issuehistoryview ) %]<li class="active">[% ELSE %]<li>[% END %]
 <a href="/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=[% biblio_object_id | url  %]" >Checkout history</a></li>
 [% IF ( CAN_user_tools_view_system_logs ) %][% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&amp;modules=CATALOGUING&amp;action=MODIFY&amp;object=[% biblio_object_id | url  %]">Modification log</a> </li>[% END %]
-[% IF ( CAN_user_stockrotation_can_add_items_rotas ) %][% IF ( stockrotationview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/catalogue/stockrotation.pl?biblionumber=[% biblio_object_id %]">Rota</a> </li>[% END %]
+[% IF ( CAN_user_stockrotation_can_add_items_rotas && Koha.Preference('StockRotation') ) %][% IF ( stockrotationview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/catalogue/stockrotation.pl?biblionumber=[% biblio_object_id %]">Rota</a> </li>[% END %]
 </ul>
 </div>
 
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc
index 217f1a1cd3..d4a6ad2b1c 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc
@@ -1,3 +1,22 @@
+[% USE Koha %]
+
+<script type="text/javascript">//<![CDATA[
+    $(document).ready(function() {
+        var path = location.pathname.substring(1);
+        if (path.indexOf("labels") >= 0 && path.indexOf("spine") < 0 ) {
+          $('#navmenulist a[href$="/cgi-bin/koha/labels/label-home.pl"]').css('font-weight','bold');
+        } else if (path.indexOf("patroncards") >= 0 ) {
+          $('#navmenulist a[href$="/cgi-bin/koha/patroncards/home.pl"]').css('font-weight','bold');
+        } else if (path.indexOf("patron_lists") >= 0 ) {
+          $('#navmenulist a[href$="/cgi-bin/koha/patron_lists/lists.pl"]').css('font-weight','bold');
+        } else if ((path+location.search).indexOf("batchMod.pl?del=1") >= 0 ) {
+          $('#navmenulist a[href$="/cgi-bin/koha/tools/batchMod.pl?del=1"]').css('font-weight','bold');
+        } else {
+          $('#navmenulist a[href$="/' + path + '"]').css('font-weight','bold');
+        }
+    });
+//]]>
+</script>
 <div id="navmenu">
 <div id="navmenulist">
 <ul>
@@ -38,7 +57,7 @@
     [% IF ( CAN_user_tools_batch_upload_patron_images ) %]
 	<li><a href="/cgi-bin/koha/tools/picture-upload.pl">Upload patron images</a></li>
     [% END %]
-    [% IF ( CAN_user_stockrotation_can_edit_rotas ) %]
+    [% IF ( CAN_user_stockrotation_can_edit_rotas && Koha.Preference('StockRotation') ) %]
     <li><a href="/cgi-bin/koha/tools/stockrotation.pl">Stock rotation</a></li>
     [% END %]
 </ul>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
index 4724d0089e..0ff70a27dd 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
@@ -1,3 +1,5 @@
+[% USE Koha %]
+
 [% INCLUDE 'doc-head-open.inc' %]
 <title>Koha &rsaquo; Tools</title>
 [% INCLUDE 'doc-head-close.inc' %]
@@ -70,7 +72,7 @@
 	<dd>Upload patron images in a batch or one at a time</dd>
     [% END %]
 
-    [% IF ( CAN_user_stockrotation_can_edit_rotas ) %]
+    [% IF ( CAN_user_stockrotation_can_edit_rotas && Koha.Preference('StockRotation') ) %]
     <dt><a href="/cgi-bin/koha/tools/stockrotation.pl">Stock rotation</a></dt>
     <dd>Manage Stock rotation rotas, rota stages and rota items</dd>
     [% END %]
diff --git a/tools/stockrotation.pl b/tools/stockrotation.pl
index b3bf48a689..19f71ddee0 100755
--- a/tools/stockrotation.pl
+++ b/tools/stockrotation.pl
@@ -28,6 +28,7 @@ use Modern::Perl;
 use CGI;
 
 use C4::Auth;
+use C4::Context;
 use C4::Output;
 
 use Koha::Libraries;
@@ -39,6 +40,12 @@ use Koha::Util::StockRotation qw(:ALL);
 
 my $input = new CGI;
 
+unless (C4::Context->preference('StockRotation')) {
+    # redirect to Intranet home if self-check is not enabled
+    print $input->redirect("/cgi-bin/koha/mainpage.pl");
+    exit;
+}
+
 my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
     {
         template_name   => 'tools/stockrotation.tt',
-- 
2.13.4