Bugzilla – Attachment 7054 Details for
Bug 7097
HidePatronName not hiding in all places
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed Patch
0001-Bug-7097-HidePatronName-not-hiding-on-issue-history.patch (text/plain), 2.45 KB, created by
Ian Walls
on 2012-01-05 18:29:37 UTC
(
hide
)
Description:
Proposed Patch
Filename:
MIME Type:
Creator:
Ian Walls
Created:
2012-01-05 18:29:37 UTC
Size:
2.45 KB
patch
obsolete
>From 7c37a67c637792955cea8c3fbfb6724dd5d7db9a Mon Sep 17 00:00:00 2001 >From: Ian Walls <ian.walls@bywatersolutions.com> >Date: Thu, 5 Jan 2012 13:17:53 -0500 >Subject: [PATCH] Bug 7097: HidePatronName not hiding on issue history > >HidePatronName wasn't being respected on a titles Checkout History tab. This patch >exports the preference to the template (if set), and then toggles the display between >patron cardnumber (if 'on') or the name (if 'off') > >To test: > >Enable HidePatronName >Go to the Checkout History tab of an item that has been checked out before >You should see the patron's cardnumber instead of their surname, firstname >--- > catalogue/issuehistory.pl | 4 ++++ > .../prog/en/modules/catalogue/issuehistory.tt | 2 +- > 2 files changed, 5 insertions(+), 1 deletions(-) > >diff --git a/catalogue/issuehistory.pl b/catalogue/issuehistory.pl >index 0d774ea..3fb936e 100755 >--- a/catalogue/issuehistory.pl >+++ b/catalogue/issuehistory.pl >@@ -45,6 +45,10 @@ my $params = $query->Vars; > my $biblionumber = $params->{'biblionumber'}; > my $itemnumber = $params->{'itemnumber'}; > >+if (C4::Context->preference("HidePatronName")) { >+ $template->param(HidePatronName => 1); >+} >+ > my ($issues,$biblio,$barcode); > if ($itemnumber){ > $issues=GetItemIssues($itemnumber); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt >index bc2490f..de5db0e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt >@@ -34,7 +34,7 @@ > <tbody> > [% FOREACH issue IN issues %] > [% UNLESS ( loop.odd ) %]<tr class="highlight">[% ELSE %]<tr>[% END %] >- <td><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% issue.borrowernumber %]">[% issue.surname %][% IF ( issue.firstname ) %], [% issue.firstname %][% END %]</a></td> >+ <td><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% issue.borrowernumber %]">[% IF HidePatronName %][% issue.cardnumber %][% ELSE %][% issue.surname %][% IF ( issue.firstname ) %], [% issue.firstname %][% END %][% END %]</a></td> > <td>[% IF ( issue.barcode ) %] > <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% issue.biblionumber %]&itemnumber=[% issue.itemnumber %]">[% issue.barcode %]</a> > [% ELSE %] >-- >1.7.4.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7097
:
7054
|
7055