Bugzilla – Attachment 70550 Details for
Bug 19979
Search.t fails on facet info with one branch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19979: Fix get_facets_info test in Search.t
Bug-19979-Fix-getfacetsinfo-test-in-Searcht.patch (text/plain), 1.65 KB, created by
Marcel de Rooy
on 2018-01-16 13:32:20 UTC
(
hide
)
Description:
Bug 19979: Fix get_facets_info test in Search.t
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-01-16 13:32:20 UTC
Size:
1.65 KB
patch
obsolete
>From 5e286f8dd02f865c5b951a70746c8539b395112c Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 16 Jan 2018 14:28:36 +0100 >Subject: [PATCH] Bug 19979: Fix get_facets_info test in Search.t >Content-Type: text/plain; charset=utf-8 > >The test should remove the holdingbranch key in the expected results when >there is only one branch. >See the logic in C4::Koha. > >Test plan: >[1] Run Search.t on a database with multiple branches. >[2] Run Search.t on a database with one branch. Without this patch the test > would fail: Failed test '_get_facets_info returns the correct data'. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Search.t | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/t/db_dependent/Search.t b/t/db_dependent/Search.t >index ba277bc..ba5e531 100644 >--- a/t/db_dependent/Search.t >+++ b/t/db_dependent/Search.t >@@ -865,6 +865,8 @@ if ( $indexing_mode eq 'dom' ) { > 'su-ut' => { 'expanded' => undef, > 'label_value' => "Titles" } > }; >+ delete $expected_facets_info_marc21->{holdingbranch} >+ if Koha::Libraries->search->count == 1; > is_deeply( $facets_info, $expected_facets_info_marc21, > "_get_facets_info returns the correct data"); > >@@ -959,6 +961,8 @@ sub run_unimarc_search_tests { > 'su-ut' => { 'expanded' => undef, > 'label_value' => "Titles" } > }; >+ delete $expected_facets_info_unimarc->{holdingbranch} >+ if Koha::Libraries->search->count == 1; > is_deeply( $facets_info, $expected_facets_info_unimarc, > "_get_facets_info returns the correct data"); > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19979
:
70550
|
72266
|
72267