Bugzilla – Attachment 70552 Details for
Bug 19839
invoice.pl warns about bad variable scope
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19839: Removed Warning
Bug-19839-Removed-Warning.patch (text/plain), 947 bytes, created by
Marcel de Rooy
on 2018-01-16 13:49:21 UTC
(
hide
)
Description:
Bug 19839: Removed Warning
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-01-16 13:49:21 UTC
Size:
947 bytes
patch
obsolete
>From 16fb3ce290808e126d2e335cbe3244376e7926bb Mon Sep 17 00:00:00 2001 >From: Grace Smyth <gracesmythh@gmail.com> >Date: Tue, 16 Jan 2018 03:41:15 +0000 >Subject: [PATCH] Bug 19839: Removed Warning >Content-Type: text/plain; charset=utf-8 > >Test Plan >[1.] Check the patch to see that I have removed: >$template->param( uncertainprices => 1 ); from line 204 as Mr Druart has instructed to do >(to get to the patch see the comment above by Mr Druart) > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > acqui/invoice.pl | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/acqui/invoice.pl b/acqui/invoice.pl >index dd1360f..1ed46cf 100755 >--- a/acqui/invoice.pl >+++ b/acqui/invoice.pl >@@ -201,7 +201,6 @@ sub get_infos { > $line{budget_name} = $budget->{budget_name}; > > if ( $line{uncertainprice} ) { >- $template->param( uncertainprices => 1 ); > $line{rrp} .= ' (Uncertain)'; > } > if ( $line{'title'} ) { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19839
:
70544
| 70552