From f6773473af0e6f4e9e6bdf46fd695175e8454550 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Thu, 18 Jan 2018 15:40:15 +0100 Subject: [PATCH] Bug 20031: CGI param in list context warn in guided_reports.pl Content-Type: text/plain; charset=utf-8 Resolve warn: CGI::param called in list context from package CGI::Compile::ROOT::usr_share_koha_shadowclone_reports_guided_reports_2epl line 794, this can lead to vulnerabilities. [NOTE: line number from older Koha version.] Test plan: Looking at this change should convince you already. Another look at this routine in C4/Output.pm would be bonus. Signed-off-by: Marcel de Rooy --- reports/guided_reports.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl index 106ddb5..423179e 100755 --- a/reports/guided_reports.pl +++ b/reports/guided_reports.pl @@ -827,7 +827,7 @@ elsif ($phase eq 'Run this report'){ 'name' => $name, 'notes' => $notes, 'errors' => defined($errors) ? [ $errors ] : undef, - 'pagination_bar' => pagination_bar($url, $totpages, $input->param('page')), + 'pagination_bar' => pagination_bar($url, $totpages, scalar $input->param('page')), 'unlimited_total' => $total, 'sql_params' => \@sql_params, ); -- 2.1.4