Bugzilla – Attachment 70700 Details for
Bug 20001
ILL: Adding a 'new request' from OPAC is not possible
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20001: Fix confusion between array and arrayref
Bug-20001-Fix-confusion-between-array-and-arrayref.patch (text/plain), 1.81 KB, created by
Mark Tompsett
on 2018-01-18 17:36:17 UTC
(
hide
)
Description:
Bug 20001: Fix confusion between array and arrayref
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2018-01-18 17:36:17 UTC
Size:
1.81 KB
patch
obsolete
>From 4c09b27a883c4f2730be25ecc4288bb6429ddc55 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 18 Jan 2018 12:49:12 -0300 >Subject: [PATCH] Bug 20001: Fix confusion between array and arrayref > >Illrequest->available_backends always returned only 1 element > >TEST PLAN >--------- >See bug 7317 comment #20 for configuring ILL >Make sure to restart_all >Strangely, ILLIBS didn't exist, but IL did in default install, > so use that as the patron code in your koha-conf.xml >Make sure to turn on the ILL related system preference. > >1) Configure ILL. > -- this is the hard part. Hopefully the above will give you > enough. >2) open OPAC and log in >3) Click the 'your interlibrary loan request' in the left pane >4) Click the 'Create a new request' button. > -- when you hover your mouse over the links for the backends, > they will have ARRAY(...) instead of a meaningful name. > This is what triggers the error (see comment #7). >5) Run the following commands > git checkout -b bug_20001 origin/master > git bz apply 20001 > reset_all >6) Refresh the OPAC page, and repeat step 4. > -- when hovering your mouse over the links for the backends, > they will have meaningful values now. >7) run koha qa test tools. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > Koha/Illrequest.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm >index b6585c2..99b97bd 100644 >--- a/Koha/Illrequest.pm >+++ b/Koha/Illrequest.pm >@@ -478,8 +478,8 @@ Return a list of available backends. > > sub available_backends { > my ( $self ) = @_; >- my @backends = $self->_config->available_backends; >- return \@backends; >+ my $backends = $self->_config->available_backends; >+ return $backends; > } > > =head3 available_actions >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20001
:
70696
|
70700
|
70701
|
70737