From 5a640e0c6306332cbeafb6f62eebcc5443ba3653 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 18 Jan 2018 12:49:12 -0300 Subject: [PATCH] Bug 20001: Fix confusion between array and arrayref Illrequest->available_backends always returned only 1 element TEST PLAN --------- See bug 7317 comment #20 for configuring ILL Make sure to restart_all Strangely, ILLIBS didn't exist, but IL did in default install, so use that as the patron code in your koha-conf.xml Make sure to turn on the ILL related system preference. 1) Configure ILL. -- this is the hard part. Hopefully the above will give you enough. 2) open OPAC and log in 3) Click the 'your interlibrary loan request' in the left pane 4) Click the 'Create a new request' button. -- when you hover your mouse over the links for the backends, they will have ARRAY(...) instead of a meaningful name. This is what triggers the error (see comment #7). 5) Run the following commands git checkout -b bug_20001 origin/master git bz apply 20001 restart_all 6) Refresh the OPAC page, and repeat step 4. -- when hovering your mouse over the links for the backends, they will have meaningful values now. 7) run koha qa test tools. Signed-off-by: Mark Tompsett --- Koha/Illrequest.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm index b6585c2..99b97bd 100644 --- a/Koha/Illrequest.pm +++ b/Koha/Illrequest.pm @@ -478,8 +478,8 @@ Return a list of available backends. sub available_backends { my ( $self ) = @_; - my @backends = $self->_config->available_backends; - return \@backends; + my $backends = $self->_config->available_backends; + return $backends; } =head3 available_actions -- 2.1.4