From 1a4d36991f10974ee01633b2233129cb37c6be22 Mon Sep 17 00:00:00 2001 From: Stefan Berndtsson Date: Wed, 17 Jan 2018 10:55:45 +0100 Subject: [PATCH] Syspref for not setting alert flag when book is available (not on loan) https://bugs.koha-community.org/show_bug.cgi?id=20059 --- C4/SIP/ILS/Transaction/Checkin.pm | 5 +++++ installer/data/mysql/atomicupdate/sip-no-alert-for-available.sql | 2 ++ .../prog/en/modules/admin/preferences/circulation.pref | 6 ++++++ 3 files changed, 13 insertions(+) create mode 100644 installer/data/mysql/atomicupdate/sip-no-alert-for-available.sql diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm index 1e138bc..88e4ba2 100644 --- a/C4/SIP/ILS/Transaction/Checkin.pm +++ b/C4/SIP/ILS/Transaction/Checkin.pm @@ -11,6 +11,7 @@ use strict; use C4::SIP::ILS::Transaction; +use C4::Context; use C4::Circulation; use C4::Reserves qw( ModReserveAffect ); use C4::Items qw( ModItemTransfer ); @@ -69,6 +70,10 @@ sub do_checkin { $self->alert(!$return); # ignoring messages: NotIssued, IsPermanent, WasLost, WasTransfered + if(C4::Context->preference('SipNoAlertForAvailable') && $messages->{NotIssued}) { + $self->alert(0); + } + # biblionumber, biblioitemnumber, itemnumber # borrowernumber, reservedate, branchcode # cancellationdate, found, reservenotes, priority, timestamp diff --git a/installer/data/mysql/atomicupdate/sip-no-alert-for-available.sql b/installer/data/mysql/atomicupdate/sip-no-alert-for-available.sql new file mode 100644 index 0000000..c8b9fd2 --- /dev/null +++ b/installer/data/mysql/atomicupdate/sip-no-alert-for-available.sql @@ -0,0 +1,2 @@ +INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type`) VALUES +('SipNoAlertForAvailable', '0', '', 'Do not set alert flag when NotIssued is returned', 'YesNo'); diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref index 6589e3e..9a63a77 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref @@ -498,6 +498,12 @@ Circulation: yes: Cumulate no: "Don't cumulate" - the restriction periods. + - + - pref: SipNoAlertForAvailable + choices: + yes: Do not set alert + no: Set alert + - for returned books that are not issued. Holds Policy: - - pref: AllowHoldItemTypeSelection -- 2.7.4