Bugzilla – Attachment 70803 Details for
Bug 20063
$9 is lost when cataloguing authority records
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20063: (bug 18811 follow-up) Allow hidden $9 subfields
Bug-20063-bug-18811-follow-up-Allow-hidden-9-subfi.patch (text/plain), 3.15 KB, created by
Jonathan Druart
on 2018-01-22 16:45:31 UTC
(
hide
)
Description:
Bug 20063: (bug 18811 follow-up) Allow hidden $9 subfields
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-01-22 16:45:31 UTC
Size:
3.15 KB
patch
obsolete
>From adaa2ad86ae4021b7846de9930c2032c425a6691 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 17 Jan 2018 14:26:38 +0100 >Subject: [PATCH] Bug 20063: (bug 18811 follow-up) Allow hidden $9 subfields > >Although we could argue that the user should make all $9 subfields >visible, this might be a good compromise. It selectively reverts the >change from the first patch by accepting $9 subfields without checking >the hidden flag in the framework. > >Test plan: >[1] Make a subfield $9 visible for some authority field. >[2] Put a value in it somewhere in authorities.pl >[3] Make subfield $9 invisible in the auth framework. >[4] Open and save the adjusted authority record. >[5] Check the marcxml of this record. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > authorities/authorities.pl | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/authorities/authorities.pl b/authorities/authorities.pl >index 84fba09a07..7ffb0109ba 100755 >--- a/authorities/authorities.pl >+++ b/authorities/authorities.pl >@@ -404,7 +404,7 @@ sub build_tabs { > $subfield = '@'; > } > next if ( $tagslib->{$tag}->{$subfield}->{tab} ne $tabloop ); >- next if $tagslib->{$tag}->{$subfield}->{hidden}; >+ next if $tagslib->{$tag}->{$subfield}->{hidden} && $subfield ne '9'; > push( > @subfields_data, > &create_input( >@@ -420,7 +420,7 @@ sub build_tabs { > my $value = $subfields[$subfieldcount][1]; > next if ( length $subfield != 1 ); > next if ( $tagslib->{$tag}->{$subfield}->{tab} ne $tabloop ); >- next if $tagslib->{$tag}->{$subfield}->{hidden}; >+ next if $tagslib->{$tag}->{$subfield}->{hidden} && $subfield ne '9'; > push( > @subfields_data, > &create_input( >@@ -437,7 +437,7 @@ sub build_tabs { > next if ( length $subfield != 1 ); > next if ( $tagslib->{$tag}->{$subfield}->{tab} ne $tabloop ); > next if ( $tag < 10 ); >- next if $tagslib->{$tag}->{$subfield}->{hidden}; >+ next if $tagslib->{$tag}->{$subfield}->{hidden} && $subfield ne '9'; > next if ( defined( $field->subfield($subfield) ) ); > push( > @subfields_data, >@@ -476,7 +476,7 @@ sub build_tabs { > my @subfields_data; > foreach my $subfield ( sort( keys %{ $tagslib->{$tag} } ) ) { > next if ( length $subfield != 1 ); >- next if $tagslib->{$tag}->{$subfield}->{hidden}; >+ next if $tagslib->{$tag}->{$subfield}->{hidden} && $subfield ne '9'; > next if ( $tagslib->{$tag}->{$subfield}->{tab} ne $tabloop ); > push( > @subfields_data, >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20063
: 70803