Bugzilla – Attachment 70817 Details for
Bug 19985
TestBuilder.t fails if default circ rule exists
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19985: Make TestBuilder.t pass even if default_circ_rules is not empty
Bug-19985-Make-TestBuildert-pass-even-if-defaultci.patch (text/plain), 1.33 KB, created by
Mark Tompsett
on 2018-01-23 02:37:31 UTC
(
hide
)
Description:
Bug 19985: Make TestBuilder.t pass even if default_circ_rules is not empty
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2018-01-23 02:37:31 UTC
Size:
1.33 KB
patch
obsolete
>From a2d19e4b73e3d680c83f19f11bc672deedf0f138 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 22 Jan 2018 17:18:59 -0300 >Subject: [PATCH] Bug 19985: Make TestBuilder.t pass even if default_circ_rules > is not empty > >This table cannot contain more than 1 row, so we need to remove its data >before trying to generate a new entry. > >Test plan: >Set a default circ rule > prove t/db_dependent/TestBuilder.t >should return green > >Without this patch you get: > # Failed test 'TestBuilder should be able to create an object for every source' > # at t/db_dependent/TestBuilder.t line 78. > # got: '1' > # expected: '0' > # The following sources have not been generated correctly: DefaultCircRule > # Looks like you failed 1 test of 1. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > t/db_dependent/TestBuilder.t | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/t/db_dependent/TestBuilder.t b/t/db_dependent/TestBuilder.t >index 5ee0a6a..e69c194 100644 >--- a/t/db_dependent/TestBuilder.t >+++ b/t/db_dependent/TestBuilder.t >@@ -34,6 +34,7 @@ our $schema = Koha::Database->new->schema; > $schema->storage->txn_begin; > our $builder; > >+$schema->resultset('DefaultCircRule')->delete; # Is a singleton table > > subtest 'Start with some trivial tests' => sub { > plan tests => 7; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19985
:
70812
| 70817