Bugzilla – Attachment 70897 Details for
Bug 20012
use Modern::Perl in Reports perl scripts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20012:use Modern::Perl in Reports perl scripts
Bug-20012use-ModernPerl-in-Reports-perl-scripts.patch (text/plain), 5.67 KB, created by
Jon Knight
on 2018-01-24 18:41:22 UTC
(
hide
)
Description:
Bug 20012:use Modern::Perl in Reports perl scripts
Filename:
MIME Type:
Creator:
Jon Knight
Created:
2018-01-24 18:41:22 UTC
Size:
5.67 KB
patch
obsolete
>From c9fa7a42fb4b9a1f126778b8f31b67e91bf57abf Mon Sep 17 00:00:00 2001 >From: Charlotte Cordwell <charlotte.cordwell123@gmail.com> >Date: Thu, 18 Jan 2018 02:58:06 +0000 >Subject: [PATCH] Bug 20012:use Modern::Perl in Reports perl scripts > >Test Case: >Check the following files have been updated from >use strict; >use warnings; >to >use Modern::Perl; > >borrowers_out.pl >cat_issues_top.pl >catalogue_out.pl >catalogue_stats.pl >dictionary.pl >issues_avg_stats.pl >issues_stats.pl >itemslost.pl >manager.pl >reports-home.pl >serials_stats.pl >stats.print.pl > >Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> >--- > reports/borrowers_out.pl | 3 +-- > reports/cat_issues_top.pl | 3 +-- > reports/catalogue_out.pl | 3 +-- > reports/catalogue_stats.pl | 3 +-- > reports/dictionary.pl | 3 +-- > reports/issues_avg_stats.pl | 3 +-- > reports/issues_stats.pl | 3 +-- > reports/itemslost.pl | 3 +-- > reports/manager.pl | 3 +-- > reports/reports-home.pl | 3 +-- > reports/serials_stats.pl | 3 +-- > reports/stats.print.pl | 3 +-- > 12 files changed, 12 insertions(+), 24 deletions(-) > >diff --git a/reports/borrowers_out.pl b/reports/borrowers_out.pl >index 50c73b0..762a0d4 100755 >--- a/reports/borrowers_out.pl >+++ b/reports/borrowers_out.pl >@@ -17,8 +17,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-use warnings; >+use Modern::Perl; > > use CGI qw ( -utf8 ); > use C4::Auth; >diff --git a/reports/cat_issues_top.pl b/reports/cat_issues_top.pl >index 958a72e..e7a315f 100755 >--- a/reports/cat_issues_top.pl >+++ b/reports/cat_issues_top.pl >@@ -18,8 +18,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-#use warnings; FIXME - Bug 2505 >+use Modern::Perl; > use C4::Auth; > use CGI qw ( -utf8 ); > use C4::Context; >diff --git a/reports/catalogue_out.pl b/reports/catalogue_out.pl >index 0c53a79..3b0fdd8 100755 >--- a/reports/catalogue_out.pl >+++ b/reports/catalogue_out.pl >@@ -17,8 +17,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-use warnings; >+use Modern::Perl; > use CGI qw ( -utf8 ); > > use C4::Auth; >diff --git a/reports/catalogue_stats.pl b/reports/catalogue_stats.pl >index dcd2889..b7bd98a 100755 >--- a/reports/catalogue_stats.pl >+++ b/reports/catalogue_stats.pl >@@ -18,8 +18,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-#use warnings; FIXME - Bug 2505 >+use Modern::Perl; > use C4::Auth; > use CGI qw ( -utf8 ); > use C4::Context; >diff --git a/reports/dictionary.pl b/reports/dictionary.pl >index 7d86f8d..bca95ce 100755 >--- a/reports/dictionary.pl >+++ b/reports/dictionary.pl >@@ -17,8 +17,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > use CGI::Carp qw(fatalsToBrowser warningsToBrowser); >-use strict; >-use warnings; >+use Modern::Perl; > use C4::Auth; > use CGI qw ( -utf8 ); > use C4::Output; >diff --git a/reports/issues_avg_stats.pl b/reports/issues_avg_stats.pl >index 5c35de7..cea969e 100755 >--- a/reports/issues_avg_stats.pl >+++ b/reports/issues_avg_stats.pl >@@ -18,8 +18,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-#use warnings; FIXME - Bug 2505 >+use Modern::Perl; > use C4::Auth; > use CGI qw ( -utf8 ); > use C4::Context; >diff --git a/reports/issues_stats.pl b/reports/issues_stats.pl >index 75c54ba..2da53d8 100755 >--- a/reports/issues_stats.pl >+++ b/reports/issues_stats.pl >@@ -17,8 +17,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-use warnings; >+use Modern::Perl; > > use CGI qw ( -utf8 ); > use Date::Manip; >diff --git a/reports/itemslost.pl b/reports/itemslost.pl >index 75bb067..6ca5a78 100755 >--- a/reports/itemslost.pl >+++ b/reports/itemslost.pl >@@ -25,8 +25,7 @@ This script displays lost items. > > =cut > >-use strict; >-use warnings; >+use Modern::Perl; > > use CGI qw ( -utf8 ); > use C4::Auth; >diff --git a/reports/manager.pl b/reports/manager.pl >index e9ec30e..2ff27e8 100755 >--- a/reports/manager.pl >+++ b/reports/manager.pl >@@ -17,8 +17,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-#use warnings; FIXME - Bug 2505 >+use Modern::Perl; > use CGI qw ( -utf8 ); > use C4::Auth; > use C4::Context; >diff --git a/reports/reports-home.pl b/reports/reports-home.pl >index c1e92c2..6bcc996 100755 >--- a/reports/reports-home.pl >+++ b/reports/reports-home.pl >@@ -18,8 +18,7 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > >-use strict; >-#use warnings; FIXME - Bug 2505 >+use Modern::Perl; > use CGI qw ( -utf8 ); > use C4::Auth; > use C4::Output; >diff --git a/reports/serials_stats.pl b/reports/serials_stats.pl >index 614b95f..0c5ed28 100755 >--- a/reports/serials_stats.pl >+++ b/reports/serials_stats.pl >@@ -17,8 +17,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-use warnings; >+use Modern::Perl; > use C4::Auth; > use CGI qw ( -utf8 ); > use C4::Context; >diff --git a/reports/stats.print.pl b/reports/stats.print.pl >index 9495360..5763969 100755 >--- a/reports/stats.print.pl >+++ b/reports/stats.print.pl >@@ -1,7 +1,6 @@ > #!/usr/bin/perl > >-use strict; >-#use warnings; FIXME - Bug 2505 >+use Modern::Perl; > use CGI qw ( -utf8 ); > use C4::Output; > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20012
:
70667
|
70897
|
71187