From b0a442669ede91ef7cefbf82d801ba79228cfad9 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 26 Jan 2018 13:12:16 +0000 Subject: [PATCH] Bug 19641: Follow-up - Fix update child menu option This follow-up corrects handling of clicks on the "Update child" menu option when the patron is an adult. Previously the click handler was conditionally added via template markup. This patch modifies it to use the data-tooltip attribute as an indicator that the option is disabled. To test, apply the patch and clear your browser cache if necessary. - Open an adult patron's record for viewing. - Choose More -> Update child from the toolbar menu. - The menu item should be disabled, and should show a tooltip. - Clicking the menu item should do nothing. - Open a child patron's record for viewing. - Choose More -> Update child from the toolbar menu. - The patron should be updated to an adult category. --- koha-tmpl/intranet-tmpl/prog/js/members-menu.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/members-menu.js b/koha-tmpl/intranet-tmpl/prog/js/members-menu.js index b2b105d..675f643 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/members-menu.js +++ b/koha-tmpl/intranet-tmpl/prog/js/members-menu.js @@ -57,9 +57,13 @@ $(document).ready(function(){ $(".btn-group").removeClass("open"); return false; }); - $("#updatechild").click(function(){ - update_child(); - $(".btn-group").removeClass("open"); + $("#updatechild").click(function(e){ + if( $(this).data("toggle") == "tooltip"){ // Disabled menu option has tooltip attribute + e.preventDefault(); + } else { + update_child(); + $(".btn-group").removeClass("open"); + } }); } -- 2.1.4