Bugzilla – Attachment 71179 Details for
Bug 20020
use Modern::Perl in XT scripts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20020: use Modern::Perl in XT scripts
Bug-20020-use-ModernPerl-in-XT-scripts.patch (text/plain), 4.11 KB, created by
Katrin Fischer
on 2018-02-04 13:06:55 UTC
(
hide
)
Description:
Bug 20020: use Modern::Perl in XT scripts
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-02-04 13:06:55 UTC
Size:
4.11 KB
patch
obsolete
>From e2517becf3d17ebefd0475ef2fb19b539a51503d Mon Sep 17 00:00:00 2001 >From: Charlotte Cordwell <charlotte.cordwell123@gmail.com> >Date: Thu, 18 Jan 2018 03:32:12 +0000 >Subject: [PATCH] Bug 20020: use Modern::Perl in XT scripts > >Test Case: >Check the following files have been updated from >use strict; >use warnings; >to >use Modern::Perl; > >author/podcorrectness.t >author/show-template-structure.pl >author/translatable-templates.t >author/valid-templates.t >find-license-problems >fix-old-fsf-address >single_quotes.t >verify-debian-docbook.t > >Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > xt/author/podcorrectness.t | 4 +--- > xt/author/show-template-structure.pl | 3 +-- > xt/author/translatable-templates.t | 4 +--- > xt/author/valid-templates.t | 3 +-- > xt/find-license-problems | 3 +-- > xt/fix-old-fsf-address | 3 +-- > xt/single_quotes.t | 3 +-- > xt/verify-debian-docbook.t | 4 +--- > 8 files changed, 8 insertions(+), 19 deletions(-) > >diff --git a/xt/author/podcorrectness.t b/xt/author/podcorrectness.t >index ed3fc5d728..c1f1caa78e 100644 >--- a/xt/author/podcorrectness.t >+++ b/xt/author/podcorrectness.t >@@ -1,7 +1,5 @@ > #!/usr/bin/env perl >-use strict; >-use warnings; >- >+use Modern::Perl; > =head2 podcorrectness.t > > This test file checks all perl modules in the C4 directory for POD >diff --git a/xt/author/show-template-structure.pl b/xt/author/show-template-structure.pl >index 90e5e87e87..6c234875bc 100755 >--- a/xt/author/show-template-structure.pl >+++ b/xt/author/show-template-structure.pl >@@ -17,8 +17,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-use warnings; >+use Modern::Perl; > > =head1 NAME > >diff --git a/xt/author/translatable-templates.t b/xt/author/translatable-templates.t >index e00d3f076b..cf2f816a5c 100644 >--- a/xt/author/translatable-templates.t >+++ b/xt/author/translatable-templates.t >@@ -15,9 +15,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-use warnings; >- >+use Modern::Perl; > =head2 translate-templates.t > > This test verifies that all staff and OPAC template >diff --git a/xt/author/valid-templates.t b/xt/author/valid-templates.t >index 5502d55187..d31b01e10d 100644 >--- a/xt/author/valid-templates.t >+++ b/xt/author/valid-templates.t >@@ -17,8 +17,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-use warnings; >+use Modern::Perl; > > =head1 NAME > >diff --git a/xt/find-license-problems b/xt/find-license-problems >index d0c5c3059c..c18f2c195a 100755 >--- a/xt/find-license-problems >+++ b/xt/find-license-problems >@@ -24,8 +24,7 @@ > # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > > >-use strict; >-use warnings; >+use Modern::Perl; > > use File::Find; > >diff --git a/xt/fix-old-fsf-address b/xt/fix-old-fsf-address >index 6a67d8ba7e..523db42d01 100755 >--- a/xt/fix-old-fsf-address >+++ b/xt/fix-old-fsf-address >@@ -27,8 +27,7 @@ > # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > > >-use strict; >-use warnings; >+use Modern::Perl; > > use File::Basename; > use File::Copy; >diff --git a/xt/single_quotes.t b/xt/single_quotes.t >index 3c079bb24c..4c6a9e8cd0 100755 >--- a/xt/single_quotes.t >+++ b/xt/single_quotes.t >@@ -17,8 +17,7 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use warnings; >-use strict; >+use Modern::Perl; > use Test::More tests => 1; > use File::Find; > >diff --git a/xt/verify-debian-docbook.t b/xt/verify-debian-docbook.t >index 94a6c21246..97c8e948ad 100755 >--- a/xt/verify-debian-docbook.t >+++ b/xt/verify-debian-docbook.t >@@ -20,9 +20,7 @@ > # This runs 'xmllint' (part of libxml2-utils) over each xml file that > # generates the koha-common man pages and ensures they're correct. > >-use strict; >-use warnings; >- >+use Modern::Perl; > use Test::More qw(no_plan); > > my $doc_dir = 'debian/docs'; >-- >2.14.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20020
:
70673
|
70903
| 71179