From 93da7d57c3473f4bd86dde1fd7f676cee08d2485 Mon Sep 17 00:00:00 2001 From: Zoe Bennett Date: Thu, 18 Jan 2018 00:45:11 +0000 Subject: [PATCH] Bug 19995: use Modern::Perl in Catalogue perl scripts Test Plan: - Check that it now says 'use Modern::Perl;' and not 'use strict; use warnings;' in the following catalogue perl scripts. MARCdetail.pl export.pl image.pl imageviewer.pl issuehistory.pl labeledMARCdetail.pl moredetail.pl search.pl showmarc.pl updateitem.pl Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer --- catalogue/MARCdetail.pl | 3 +-- catalogue/export.pl | 3 +-- catalogue/image.pl | 3 +-- catalogue/imageviewer.pl | 3 +-- catalogue/issuehistory.pl | 3 +-- catalogue/labeledMARCdetail.pl | 3 +-- catalogue/moredetail.pl | 3 +-- catalogue/search.pl | 3 +-- catalogue/showmarc.pl | 3 +-- catalogue/updateitem.pl | 3 +-- 10 files changed, 10 insertions(+), 20 deletions(-) diff --git a/catalogue/MARCdetail.pl b/catalogue/MARCdetail.pl index 6474f3e1fa..8940471456 100755 --- a/catalogue/MARCdetail.pl +++ b/catalogue/MARCdetail.pl @@ -43,8 +43,7 @@ the items attached to the biblio =cut -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; use CGI qw ( -utf8 ); use HTML::Entities; diff --git a/catalogue/export.pl b/catalogue/export.pl index c10686c12b..ac8a202dad 100755 --- a/catalogue/export.pl +++ b/catalogue/export.pl @@ -1,6 +1,5 @@ #!/usr/bin/perl -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; use C4::Record; use C4::Auth; diff --git a/catalogue/image.pl b/catalogue/image.pl index 3d95b0584c..d1fcba72d2 100755 --- a/catalogue/image.pl +++ b/catalogue/image.pl @@ -23,8 +23,7 @@ # # -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); #qw(:standard escapeHTML); use C4::Context; diff --git a/catalogue/imageviewer.pl b/catalogue/imageviewer.pl index 06c4bbed92..009b82ecf1 100755 --- a/catalogue/imageviewer.pl +++ b/catalogue/imageviewer.pl @@ -17,8 +17,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Auth; diff --git a/catalogue/issuehistory.pl b/catalogue/issuehistory.pl index d154a2111f..5cf04058e9 100755 --- a/catalogue/issuehistory.pl +++ b/catalogue/issuehistory.pl @@ -16,8 +16,7 @@ # along with Koha; if not, see . -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Auth; diff --git a/catalogue/labeledMARCdetail.pl b/catalogue/labeledMARCdetail.pl index d84c75f251..a033b07181 100755 --- a/catalogue/labeledMARCdetail.pl +++ b/catalogue/labeledMARCdetail.pl @@ -17,8 +17,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use HTML::Entities; use MARC::Record; diff --git a/catalogue/moredetail.pl b/catalogue/moredetail.pl index 5bc1d2fa80..56242406cb 100755 --- a/catalogue/moredetail.pl +++ b/catalogue/moredetail.pl @@ -19,8 +19,7 @@ # along with Koha; if not, see . -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; use C4::Koha; use CGI qw ( -utf8 ); use HTML::Entities; diff --git a/catalogue/search.pl b/catalogue/search.pl index 9f752217c7..812bd4fd6c 100755 --- a/catalogue/search.pl +++ b/catalogue/search.pl @@ -132,8 +132,7 @@ Not yet completed... =cut -use strict; # always use -#use warnings; FIXME - Bug 2505 +use Modern::Perl; ## STEP 1. Load things that are used in both search page and # results page and decide which template to load, operations diff --git a/catalogue/showmarc.pl b/catalogue/showmarc.pl index 11c4f39295..e8f69394cc 100755 --- a/catalogue/showmarc.pl +++ b/catalogue/showmarc.pl @@ -20,8 +20,7 @@ # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -use strict; -use warnings; +use Modern::Perl; # standard or CPAN modules used use CGI qw(:standard -utf8); diff --git a/catalogue/updateitem.pl b/catalogue/updateitem.pl index 2e54eac595..b7cbc9445c 100755 --- a/catalogue/updateitem.pl +++ b/catalogue/updateitem.pl @@ -17,8 +17,7 @@ # # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Auth; use C4::Context; -- 2.14.1