Bugzilla – Attachment 71270 Details for
Bug 20147
Allow translating prompt in label edit batch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20147: Allow translating prompt in label edit batch
0001-Bug-20147-Allow-translating-prompt-in-label-edit-bat.patch (text/plain), 1.84 KB, created by
paxed
on 2018-02-07 06:19:29 UTC
(
hide
)
Description:
Bug 20147: Allow translating prompt in label edit batch
Filename:
MIME Type:
Creator:
paxed
Created:
2018-02-07 06:19:29 UTC
Size:
1.84 KB
patch
obsolete
>From 2a555556fd06340a49c23fa1a0498a6af498f65c Mon Sep 17 00:00:00 2001 >From: Pasi Kallinen <pasi.kallinen@joensuu.fi> >Date: Tue, 6 Feb 2018 14:17:45 +0200 >Subject: [PATCH] Bug 20147: Allow translating prompt in label edit batch > >Fix one untranslatable prompt in the label batch edit. > >Test plan: > >1) Go to Home -> Tools -> Label creator >2) Click on New -> Label batch >3) Add items to the batch >4) Select any of the items >5) Click on "Remove selected items" >6) Note the popup text >7) Apply patch, update a language, translate the msgid > "Are you sure you want to remove label number(s): %s from this batch?" >8) Repeat 1-6. The popup text should now be translated. > >Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt >index ed905a9076..6fbb64ebd3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt >@@ -41,7 +41,7 @@ > } > getstr = items.join("&"); > item_msg = item_num.join(", "); >- var msg = "Are you sure you want to remove label number(s): " + item_msg + " from this batch?" >+ var msg = _("Are you sure you want to remove label number(s): %s from this batch?").format(item_msg); > } else if (document.items.action.checked) { > alert(_("Deletion of label from a batch with only one label will delete the batch.") + "\n\n" + _("If this is what you want, select the 'Delete batch' option from the toolbar")); > return; // no deletion for single item batch >-- >2.11.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20147
:
71270
|
72264