From 33b2534717b5c02d5161b235fc34449471cb1c50 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 21 Dec 2017 15:14:22 -0300 Subject: [PATCH] Bug 15752: (QA follow-up) Remove unecessary redirect We are on circulation.pl, no need to redirect. Signed-off-by: Katrin Fischer --- circ/circulation.pl | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/circ/circulation.pl b/circ/circulation.pl index b41f87d..46d5ec4 100755 --- a/circ/circulation.pl +++ b/circ/circulation.pl @@ -83,12 +83,18 @@ if (!C4::Context->userenv){ my $barcodes = []; my $barcode = $query->param('barcode'); +my $findborrower; +my $autoswitched; if (C4::Context->preference("AutoSwitchPatron") && $barcode) { if (Koha::Patrons->search( { cardnumber => $barcode} )->count() > 0) { - print $query->redirect("/cgi-bin/koha/circ/circulation.pl?findborrower=$barcode&autoswitched=1"); + $findborrower = $barcode; + undef $barcode; + $autoswitched = 1; } } +$findborrower ||= $query->param('findborrower') || q{}; +$findborrower =~ s|,| |g; # Barcode given by user could be '0' if ( $barcode || ( defined($barcode) && $barcode eq '0' ) ) { @@ -153,9 +159,6 @@ for (@failedreturns) { $return_failed{$_} = 1; } my $searchtype = $query->param('searchtype') || q{contain}; -my $findborrower = $query->param('findborrower') || q{}; -$findborrower =~ s|,| |g; - my $branch = C4::Context->userenv->{'branch'}; if (C4::Context->preference("DisplayClearScreenButton")) { @@ -664,7 +667,7 @@ $template->param( has_modifications => $has_modifications, override_high_holds => $override_high_holds, nopermission => scalar $query->param('nopermission'), - autoswitched => $query->param("autoswitched"), + autoswitched => $autoswitched, ); output_html_with_http_headers $query, $cookie, $template->output; -- 2.1.4