From 0173bcfa70b27da633d273f084fd1e935325a235 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 6 Feb 2018 12:34:34 -0300 Subject: [PATCH] Bug 20144: [sql_modes] Remove HAVING clause from GetTopIssues Fix for: 'koha_kohadev.b.title' isn't in GROUP BY t/db_dependent/Circulation/GetTopIssues.t Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice --- C4/Circulation.pm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 75215db2e2..075ed60f65 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -3975,6 +3975,7 @@ sub GetTopIssues { my $dbh = C4::Context->dbh; my $query = q{ + SELECT * FROM ( SELECT b.biblionumber, b.title, b.author, bi.itemtype, bi.publishercode, bi.place, bi.publicationyear, b.copyrightdate, bi.pages, bi.size, i.ccode, SUM(i.issues) AS count @@ -4012,11 +4013,13 @@ sub GetTopIssues { } $query .= q{ - GROUP BY b.biblionumber - HAVING count > 0 + GROUP BY b.biblionumber, b.title, b.author, bi.itemtype, bi.publishercode, + bi.place, bi.publicationyear, b.copyrightdate, bi.pages, bi.size, + i.ccode ORDER BY count DESC }; + $query .= q{ ) xxx WHERE count > 0 }; $count = int($count); if ($count > 0) { $query .= "LIMIT $count"; -- 2.14.2