From 5d9bc4b639852b2a7e49b1fd0facfd2183a0b838 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 6 Feb 2018 12:51:19 -0300 Subject: [PATCH] Bug 20144: [sql_modes] Set value for pending_offline_operations.timestamp Not null Fix for: Incorrect datetime value: 'null' for column 'timestamp' Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice --- t/db_dependent/Circulation/OfflineOperation.t | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/t/db_dependent/Circulation/OfflineOperation.t b/t/db_dependent/Circulation/OfflineOperation.t index 387ae6427f..c50524dd51 100644 --- a/t/db_dependent/Circulation/OfflineOperation.t +++ b/t/db_dependent/Circulation/OfflineOperation.t @@ -2,6 +2,8 @@ use Modern::Perl; use C4::Circulation; + +use Koha::DateUtils qw( dt_from_string output_pref ); use Koha::Library; use Test::More tests => 7; @@ -51,12 +53,14 @@ my $samplebranch1 = { }; Koha::Library->new($samplebranch1)->store; +my $now = dt_from_string->truncate( to => 'minute' ); + #Begin Tests #Test AddOfflineOperation is( AddOfflineOperation( 'User1', $samplebranch1->{branchcode}, - 'null', 'Action1', 'CODE', 'Cardnumber1', 10 + $now, 'Action1', 'CODE', 'Cardnumber1', 10 ), 'Added.', "OfflineOperation has been added" @@ -71,7 +75,8 @@ is_deeply( operationid => $offline_id, userid => 'User1', branchcode => $samplebranch1->{branchcode}, - timestamp => "0000-00-00 00:00:00", + # FIXME sounds like we need a 'timestamp' dateformat + timestamp => output_pref({ dt => $now, dateformat => 'iso', dateonly => 0 }) . ':00', action => 'Action1', barcode => 'CODE', cardnumber => 'Cardnumber1', -- 2.14.2