Bugzilla – Attachment 71461 Details for
Bug 20144
Test suite is failing with new default SQL modes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests
Bug-20144-sqlmodes-Add-default-value-for-subscript.patch (text/plain), 1.87 KB, created by
Julian Maurice
on 2018-02-12 12:53:31 UTC
(
hide
)
Description:
Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2018-02-12 12:53:31 UTC
Size:
1.87 KB
patch
obsolete
>From 0d5bf819cfdacc42c3b7bb9f021c0712d4db638f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 6 Feb 2018 14:47:43 -0300 >Subject: [PATCH] Bug 20144: [sql_modes] Add default value for > subscription_numberpatterns.description in tests > >Fix for: >Field 'description' doesn't have a default value > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > t/db_dependent/Serials/Numberpattern.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Serials/Numberpattern.t b/t/db_dependent/Serials/Numberpattern.t >index 6a053259c7..c964ee9776 100644 >--- a/t/db_dependent/Serials/Numberpattern.t >+++ b/t/db_dependent/Serials/Numberpattern.t >@@ -28,7 +28,7 @@ $numberpattern = {}; > $rv = ModSubscriptionNumberpattern($numberpattern); > is($rv, undef, "ModSubscriptionNumberpattern({}) returns undef"); > # returns 0 because id doesn't exist >-$numberpattern = { id => 1, label => "Test numberpattern 1" }; >+$numberpattern = { id => 1, label => "Test numberpattern 1", description => '' }; > $rv = ModSubscriptionNumberpattern($numberpattern); > is($rv, '0E0', "ModSubscriptionNumberpattern({id=1,label=>'Test numberpattern 1'}) returns '0 but true'"); > >@@ -38,7 +38,7 @@ is($id, undef, "AddSubscriptionNumberpattern(undef) returns undef"); > $numberpattern = {}; > $id = AddSubscriptionNumberpattern($numberpattern); > is($id, undef, "AddSubscriptionNumberpattern({}) returns undef"); >-$numberpattern = { label => "Test numberpattern 1", numberingmethod => "{X}" }; >+$numberpattern = { label => "Test numberpattern 1", numberingmethod => "{X}", description => '' }; > $id = AddSubscriptionNumberpattern($numberpattern); > ok((defined($id) && ($id > 0)), "AddSubscriptionNumberpattern({label => 'Test numberpattern 1', numberingmethod => '{X}'}) returns numberpattern id"); > >-- >2.14.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20144
:
71410
|
71411
|
71412
|
71413
|
71414
|
71415
|
71416
|
71417
|
71418
|
71419
|
71420
|
71421
|
71422
|
71423
|
71424
|
71425
|
71427
|
71428
|
71429
|
71430
|
71431
|
71432
|
71434
|
71435
|
71436
|
71437
|
71438
|
71440
|
71441
|
71442
|
71443
|
71444
|
71445
|
71446
|
71447
|
71448
|
71449
|
71450
|
71451
|
71452
|
71453
|
71454
|
71455
|
71456
|
71457
|
71458
|
71459
|
71460
| 71461 |
71462
|
71463
|
71467
|
71564