Bugzilla – Attachment 71462 Details for
Bug 20144
Test suite is failing with new default SQL modes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20144: [sql_modes] Set subscription.numberlength and weeklength to NULL if not passed
Bug-20144-sqlmodes-Set-subscriptionnumberlength-an.patch (text/plain), 984 bytes, created by
Julian Maurice
on 2018-02-12 12:56:28 UTC
(
hide
)
Description:
Bug 20144: [sql_modes] Set subscription.numberlength and weeklength to NULL if not passed
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2018-02-12 12:56:28 UTC
Size:
984 bytes
patch
obsolete
>From c6f06de4e164117e79e1b496ea75fb0ee7b89561 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 6 Feb 2018 14:49:47 -0300 >Subject: [PATCH] Bug 20144: [sql_modes] Set subscription.numberlength and > weeklength to NULL if not passed > >Fix for: >Incorrect integer value: '' for column 'numberlength' >Incorrect integer value: '' for column 'weeklength' > >t/db_dependent/Serials/ReNewSubscription.t > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > C4/Serials.pm | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/C4/Serials.pm b/C4/Serials.pm >index 0d10b25191..ac21dad49b 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -1530,6 +1530,9 @@ sub ReNewSubscription { > ); > } > >+ $numberlength ||= 0; # Should not we raise an exception instead? >+ $weeklength ||= 0; >+ > # renew subscription > $query = qq| > UPDATE subscription >-- >2.14.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20144
:
71410
|
71411
|
71412
|
71413
|
71414
|
71415
|
71416
|
71417
|
71418
|
71419
|
71420
|
71421
|
71422
|
71423
|
71424
|
71425
|
71427
|
71428
|
71429
|
71430
|
71431
|
71432
|
71434
|
71435
|
71436
|
71437
|
71438
|
71440
|
71441
|
71442
|
71443
|
71444
|
71445
|
71446
|
71447
|
71448
|
71449
|
71450
|
71451
|
71452
|
71453
|
71454
|
71455
|
71456
|
71457
|
71458
|
71459
|
71460
|
71461
| 71462 |
71463
|
71467
|
71564