From 7126912fb0c92d2dd2499ff2c599d0156cd43e0b Mon Sep 17 00:00:00 2001 From: Pasi Kallinen Date: Wed, 14 Feb 2018 12:12:52 +0200 Subject: [PATCH] Bug 20195: Untranslatable Show/Hide title attr replacement in opac detail There's javascript code in opac detail view that tries to replace the word "Show" with "Hide" (and vice versa) in a title attribute. In addition to those words being untranslatable, a word replacement like that would not work properly when using other languages. Replace the single title attribute with two translatable strings, one for the "Show" case and one "Hide", and use the whole string instead of trying to replace a single word. Test plan: 1) Make sure OpacBrowseResults is on 2) in OPAC, search the catalog and go to the detail view 3) Hover the mouse over the "Browse results" text in the grey box on the right side. The popup text should show something like "Show pagination list (1-5 / 5)" 4) Click on the "Browse results" 5) Hover the mouse again over the text. The popup should show "Hide pagination list (1-5 / 5)" 6) Update a language xx-YY, translate the new msgids "Show pagination list (%s-%s / %s)" and "Hide pagination list (%s-%s / %s)", and install the language 7) Repeat 2-5 with that language, making sure the popup texts show up correctly in that language Signed-off-by: Pasi Kallinen --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt index 8d04573947..88b09ae1d4 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -1088,7 +1088,7 @@