Bugzilla – Attachment 71970 Details for
Bug 19908
Password should not be mandatory
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19908: Password fields in edit/add patron form should respect BorrowerMandatoryField preference
Bug-19908-Password-fields-in-editadd-patron-form-s.patch (text/plain), 2.44 KB, created by
Josef Moravec
on 2018-02-19 19:08:29 UTC
(
hide
)
Description:
Bug 19908: Password fields in edit/add patron form should respect BorrowerMandatoryField preference
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2018-02-19 19:08:29 UTC
Size:
2.44 KB
patch
obsolete
>From b967e50d45d33e92405fe6f189c0209de69f270e Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Wed, 3 Jan 2018 10:56:37 +0000 >Subject: [PATCH] Bug 19908: Password fields in edit/add patron form should > respect BorrowerMandatoryField preference > >Test plan: >0) Do not apply the patch, note the password field is always required >1) Apply the patch >2) Try to add and edit patron with and without "password" in BorrowerMandatoryField, it should always respect this setting >3) Use "Change password" button in patron toolbar, the password field >should be never required here - when leaved blank, the password is >unchanged >4) Play with minPasswordLength and RequireStrongPassword preferences, > to ensure they work as expected >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt | 2 -- > koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 -- > 2 files changed, 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt >index a86a546..df7bb77 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt >@@ -137,12 +137,10 @@ > $("#changepasswordf").validate({ > rules: { > newpassword: { >- required: true, > password_strong: true, > password_no_spaces: true > }, > newpassword2: { >- required: true, > password_match: true > } > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index cbd3784..d6a3afa 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -1247,12 +1247,10 @@ > $("#entryform").validate({ > rules: { > password: { >- required: true, > password_strong: true, > password_no_spaces: true > }, > password2: { >- required: true, > password_match: true > } > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19908
:
70242
|
71217
|
71970
|
71971
|
72159
|
72188
|
72189
|
72190
|
72503
|
72504