From fbcc5f9505e72971d9d99a2be3e60bc2cfdd53dc Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Tue, 20 Feb 2018 10:40:59 +0000 Subject: [PATCH] Bug 20067: Fix false display of authorised value for materials on staff detail page Koha didn't check for a linked authorised value category for items.materials correctly which led to displaying false information on the detail page. To test: - before applying the patch: - make sure sample data and configuration is loaded - edit any item - write 2 in the $3 materials specificed - check the details page normal view - it will display 'restocking' - apply patch - check display, it should now show "2" - link 952$3 (MARC21) to ORDER_CANCELLATION_REASON - check display again, it should now show 'restocking' --- catalogue/detail.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/catalogue/detail.pl b/catalogue/detail.pl index 58d4511..e70e58e 100755 --- a/catalogue/detail.pl +++ b/catalogue/detail.pl @@ -212,7 +212,7 @@ if ( $mss->count ) { $template->param( itemdamagedloop => GetAuthorisedValues( $mss->next->authorised_value ) ); } -$mss = Koha::MarcSubfieldStructures->search({ frameworkcode => $fw, kohafield => 'items.materials', authorised_value => { not => undef } }); +$mss = Koha::MarcSubfieldStructures->search({ frameworkcode => $fw, kohafield => 'items.materials', authorised_value => { '!=' => undef, '!=' => '' } }); my %materials_map; if ($mss->count) { my $materials_authvals = GetAuthorisedValues($mss->next->authorised_value); -- 2.1.4