Bugzilla – Attachment 72167 Details for
Bug 20199
Letters.t does not pass with new SQL modes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20199: Send a DateTime to DBIC instead of an iso formatted date
Bug-20199-Send-a-DateTime-to-DBIC-instead-of-an-is.patch (text/plain), 1.22 KB, created by
Katrin Fischer
on 2018-02-23 22:10:39 UTC
(
hide
)
Description:
Bug 20199: Send a DateTime to DBIC instead of an iso formatted date
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-02-23 22:10:39 UTC
Size:
1.22 KB
patch
obsolete
>From 56dd4cc12b187f1e633f95fcaf3e781c8a674ef6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 14 Feb 2018 14:17:58 -0300 >Subject: [PATCH] Bug 20199: Send a DateTime to DBIC instead of an iso > formatted date > >We do not need to format the date, DBIC handles DateTime correctly. > >It fixes t/db_dependent/Letters.t with new SQL modes > >Test plan: > prove t/db_dependent/Letters.t > prove t/db_dependent/Koha/Acquisition/Order.t >Must return green > >Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > Koha/Acquisition/Order.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Acquisition/Order.pm b/Koha/Acquisition/Order.pm >index 1c52497279..79fb056802 100644 >--- a/Koha/Acquisition/Order.pm >+++ b/Koha/Acquisition/Order.pm >@@ -70,7 +70,7 @@ sub store { > } > > $self->quantityreceived(0) unless $self->quantityreceived; >- $self->entrydate(output_pref( { dt => dt_from_string, dateformat => 'iso' } )) unless $self->entrydate; >+ $self->entrydate(dt_from_string) unless $self->entrydate; > > $self->ordernumber(undef) unless $self->ordernumber; > $self = $self->SUPER::store( $self ); >-- >2.14.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20199
:
71623
|
71624
|
72163
|
72166
| 72167