Bugzilla – Attachment 72201 Details for
Bug 20075
Change authority hidden attribute in sql installer files
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20075: Replace hidden -5 by 1 in data and interface
Bug-20075-Replace-hidden--5-by-1-in-data-and-inter.patch (text/plain), 2.53 KB, created by
Marcel de Rooy
on 2018-02-26 10:54:32 UTC
(
hide
)
Description:
Bug 20075: Replace hidden -5 by 1 in data and interface
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-02-26 10:54:32 UTC
Size:
2.53 KB
patch
obsolete
>From 779e8a0721f8d7aed1431067e6a72b7db5e0f615 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 26 Feb 2018 11:43:43 +0100 >Subject: [PATCH] Bug 20075: Replace hidden -5 by 1 in data and interface >Content-Type: text/plain; charset=utf-8 > >In the preceding patches we chose for 1 instead of -5. >The interface should move that direction too obviously. > >Test plan: >Test toggling between Show all and Hide all in the auth frameworks. >Run the db rev. >--- > installer/data/mysql/atomicupdate/bug_20075.sql | 6 ++++++ > .../intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt | 4 ++-- > 2 files changed, 8 insertions(+), 2 deletions(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_20075.sql > >diff --git a/installer/data/mysql/atomicupdate/bug_20075.sql b/installer/data/mysql/atomicupdate/bug_20075.sql >new file mode 100644 >index 0000000..b98d452 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_20075.sql >@@ -0,0 +1,6 @@ >+$DBversion = 'XXX'; # will be replaced by the RM >+if( CheckVersion( $DBversion ) ) { >+ $dbh->do(q|UPDATE auth_subfield_structure SET hidden=1 WHERE hidden<>0|); >+ SetVersion( $DBversion ); >+ print "Upgrade to $DBversion done (Bug 20075: Change authority hidden attribute)\n"; >+} >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >index b7a6ab2..3101ae7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >@@ -112,11 +112,11 @@ > <select name="ohidden" size="1" id="ohidden[% loo.row %]"> > [%- IF ( loo.ohidden == 0 ) -%] > <option value= "0" selected="selected">Show all</option> >- <option value="-5">Hide all</option> >+ <option value="1">Hide all</option> > [%- ELSE -%] > [%# All other non-zero values mean: Hide %] > <option value= "0">Show all</option> >- <option value="-5" selected="selected">Hide all</option> >+ <option value="1" selected="selected">Hide all</option> > [%- END -%] > </select> > </li> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20075
:
72198
|
72199
|
72200
|
72201