From 160c78a4ccbda763311b569652b460236a6b3411 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Mon, 26 Feb 2018 11:43:43 +0100 Subject: [PATCH] Bug 20074: (Follow-up) Replace hidden value -5 by 1 in data and interface Content-Type: text/plain; charset=utf-8 [ Moved from 20075 to 20074 ] Since hidden is used as a boolean, it makes more sense to save the values 0 and 1 instead of 0 and -5. Test plan: Test toggling between Show all and Hide all in the auth frameworks. Run the db rev. Signed-off-by: Marcel de Rooy --- installer/data/mysql/atomicupdate/bug20074.perl | 2 +- .../intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/installer/data/mysql/atomicupdate/bug20074.perl b/installer/data/mysql/atomicupdate/bug20074.perl index 4d2034b..941e44b 100644 --- a/installer/data/mysql/atomicupdate/bug20074.perl +++ b/installer/data/mysql/atomicupdate/bug20074.perl @@ -1,6 +1,6 @@ $DBversion = 'XXX'; # will be replaced by the RM if( CheckVersion( $DBversion ) ) { - $dbh->do(q|UPDATE auth_subfield_structure SET hidden=-5 WHERE hidden<>0|); + $dbh->do(q|UPDATE auth_subfield_structure SET hidden=1 WHERE hidden<>0|); SetVersion( $DBversion ); print "Upgrade to $DBversion done (Bug 20074: Auth_subfield_structure changes hidden attribute)\n"; } diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt index b7a6ab2..3101ae7 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt @@ -112,11 +112,11 @@ -- 2.1.4