Bugzilla – Attachment 72211 Details for
Bug 18958
If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18958 [QA Followup] - Bring back data needed for the diffbranch block of the template
Bug-18958-QA-Followup---Bring-back-data-needed-for.patch (text/plain), 1.70 KB, created by
Kyle M Hall
on 2018-02-26 14:24:01 UTC
(
hide
)
Description:
Bug 18958 [QA Followup] - Bring back data needed for the diffbranch block of the template
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2018-02-26 14:24:01 UTC
Size:
1.70 KB
patch
obsolete
>From 2e92e247de1a660b5d0429f62e21e30e54c6e70d Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatetsolutions.com> >Date: Mon, 26 Feb 2018 09:19:56 -0500 >Subject: [PATCH] Bug 18958 [QA Followup] - Bring back data needed for the > diffbranch block of the template > >--- > circ/returns.pl | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > >diff --git a/circ/returns.pl b/circ/returns.pl >index e8c9d10..34b52cc 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -161,10 +161,26 @@ if ( $query->param('reserve_id') ) { > } # FIXME else? > } else { > my $diffBranchSend = ($userenv_branch ne $diffBranchReturned) ? $diffBranchReturned : undef; >+ > # diffBranchSend tells ModReserveAffect whether document is expected in this library or not, > # i.e., whether to apply waiting status > ModReserveAffect( $itemnumber, $borrowernumber, $diffBranchSend, $reserve_id ); >- ModItemTransfer( $itemnumber, $userenv_branch, $diffBranchSend ) if $diffBranchSend; >+ >+ if ( $diffBranchSend ) { >+ ModItemTransfer( $itemnumber, $userenv_branch, $diffBranchSend ); >+ >+ my $patron = Koha::Patrons->find( $borrowernumber ); >+ my $name = $patron ? $patron->surname . ", " . $patron->title . " " . $patron->firstname : ''; >+ $template->param( >+ itemtitle => $biblio->title, >+ itemnumber => $item->itemnumber, >+ itembiblionumber => $biblio->biblionumber, >+ iteminfo => $biblio->author, >+ name => $name, >+ patron => $patron, >+ diffbranch => 1, >+ ); >+ } > } > } > >-- >2.10.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18958
:
65104
|
65150
|
65184
|
71164
|
71232
|
72210
|
72211
|
72348
|
72349
|
92159
|
92160
|
93106
|
93107
|
93108
|
93111
|
93112
|
93113
|
93216
|
93217
|
93218
|
107576
|
107577
|
107582
|
107584
|
107585
|
107586
|
108256
|
108274
|
108473
|
108474
|
108497
|
108499
|
108500
|
108936
|
108937
|
109061
|
109222
|
109640
|
109641
|
109642
|
109643
|
109644
|
109645